metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Add support for mode network

Open agileurbanite opened this issue 1 year ago • 13 comments

Description

Add support for https://mode.network a new L2 as part of the OP Superchain.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

agileurbanite avatar Feb 02 '24 19:02 agileurbanite

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 02 '24 19:02 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

agileurbanite avatar Feb 02 '24 19:02 agileurbanite

+1

okalenyk avatar Feb 06 '24 08:02 okalenyk

+1

fede2442 avatar Feb 06 '24 15:02 fede2442

+1

HermesGoodgod avatar Feb 06 '24 15:02 HermesGoodgod

+1

wolfcito avatar Feb 06 '24 15:02 wolfcito

+1

joshuanwankwo avatar Feb 06 '24 15:02 joshuanwankwo

+1

Gordiancyber avatar Feb 06 '24 21:02 Gordiancyber

+1

therevealer avatar Feb 07 '24 04:02 therevealer

+1

kohasummons avatar Feb 07 '24 08:02 kohasummons

hey @agileurbanite , thanks for your contribution. it seems that it's not possible to go to the edit network page once the network has been added (watch the video below).

https://github.com/MetaMask/metamask-extension/assets/26223211/5426740b-363b-48dd-83fb-809f0396a41c

salimtb avatar Feb 09 '24 09:02 salimtb

for context, this PR is for adding support to show L1 fees for mode network based on OP Stack deployed with Conduit

similar stuff asked for Zora

https://github.com/MetaMask/metamask-extension/pull/20501

emilianobonassi avatar Feb 09 '24 17:02 emilianobonassi

@salimtb hope the comment by @emilianobonassi provides clarity

agileurbanite avatar Feb 09 '24 19:02 agileurbanite

@bschorchit can we get visibility on this PR as well?

agileurbanite avatar Feb 19 '24 23:02 agileurbanite

bump @salimtb @bschorchit leia-youre-my-only-hope

agileurbanite avatar Feb 28 '24 16:02 agileurbanite

bump @danjm

agileurbanite avatar Mar 07 '24 12:03 agileurbanite

+1 on this!

sbvegan avatar Mar 07 '24 16:03 sbvegan

Bump @danfinlay

agileurbanite avatar Mar 09 '24 05:03 agileurbanite

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar May 17 '24 14:05 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar May 31 '24 16:05 github-actions[bot]