metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Interactive Interfaces

Open GuillaumeRx opened this issue 1 year ago • 2 comments

Description

This PR integrates the necessary changes for interactive Interfaces.

  • Setup and update the various controllers.
  • Update the SnapUIRenderer to handle an interfaceId rather than direct content.
  • Add the logic for interface state and event handling in a new InterfaceContext react context.
  • Update the different APIs to handle the newly returned values.
  • Move the UI components mapping out of the SnapUIRenderer file
  • Rework confirmations to take the SnapUIRenderer.

Related issues

Manual testing steps

  1. Fire up the interactive UI test snap [coming soon]
  2. Play with the snap

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

GuillaumeRx avatar Feb 02 '24 15:02 GuillaumeRx

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 02 '24 15:02 github-actions[bot]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Feb 06 '24 16:02 socket-security[bot]