metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

Added PoC for polling hook

Open shanejonas opened this issue 1 year ago • 11 comments

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

shanejonas avatar Feb 01 '24 15:02 shanejonas

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 01 '24 15:02 github-actions[bot]

@metamaskbot update-policies

shanejonas avatar Feb 07 '24 18:02 shanejonas

Policies updated

metamaskbot avatar Feb 07 '24 18:02 metamaskbot

@metamaskbot update-policies

shanejonas avatar Feb 07 '24 21:02 shanejonas

Policies updated

metamaskbot avatar Feb 07 '24 21:02 metamaskbot

@metamaskbot update-policies

shanejonas avatar Feb 08 '24 15:02 shanejonas

Policies updated

metamaskbot avatar Feb 08 '24 15:02 metamaskbot

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d5cf563) 68.33% compared to head (16a39fe) 68.35%.

:exclamation: Current head 16a39fe differs from pull request most recent head 65d2500. Consider uploading reports for the commit 65d2500 to get more accurate results

Files Patch % Lines
app/scripts/metamask-controller.js 0.00% 2 Missing :warning:
ui/store/actions.ts 50.00% 2 Missing :warning:
Additional details and impacted files 
@@                            Coverage Diff                             @@
##           jl/transaction-multichain-preview-test   #22770      +/-   ##
==========================================================================
+ Coverage                                   68.33%   68.35%   +0.03%     
==========================================================================
  Files                                        1088     1089       +1     
  Lines                                       42810    42812       +2     
  Branches                                    11394    11387       -7     
==========================================================================
+ Hits                                        29251    29264      +13     
+ Misses                                      13559    13548      -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 15:02 codecov[bot]

Builds ready [16a39fe]
Page Load Metrics (815 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99136115126
domContentLoaded11231742
load7269158154924
domInteractive11231742
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -79.07 KiB (-2.35%)
  • ui: 941 Bytes (0.01%)
  • common: 145.49 KiB (2.89%)

metamaskbot avatar Feb 13 '24 15:02 metamaskbot

Builds ready [65d2500]
Page Load Metrics (799 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93146113136
domContentLoaded9431784
load7159307995929
domInteractive9431784
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -79.07 KiB (-2.35%)
  • ui: 941 Bytes (0.01%)
  • common: 145.49 KiB (2.89%)

metamaskbot avatar Feb 13 '24 18:02 metamaskbot

Builds ready [f529769]
Page Load Metrics (813 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94139114136
domContentLoaded10371763
load73311058138742
domInteractive10371763
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -79.07 KiB (-2.35%)
  • ui: 941 Bytes (0.01%)
  • common: 145.49 KiB (2.89%)

metamaskbot avatar Feb 13 '24 20:02 metamaskbot

replaced by https://github.com/MetaMask/metamask-extension/pull/23010

adonesky1 avatar Feb 27 '24 19:02 adonesky1