metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

DRAFT: Multichain Transaction Controller Preview w/ enableMultichain flag on

Open jiexi opened this issue 1 year ago • 7 comments

Description

Tests are all passing with the Multichain TranasctionController added and with the enableMultichain flag on, but without changes to Extension to explicitly specify a networkClientId to use. This implies that the existing globally selected network flow is still functional even if the Multichain code paths are active but not being used directly.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jiexi avatar Jan 31 '24 19:01 jiexi

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jan 31 '24 19:01 github-actions[bot]

Builds ready [1778d09]
Page Load Metrics (814 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint961831192411
domContentLoaded105518105
load71810228147636
domInteractive105518105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 49.44 KiB (1.47%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 31 '24 20:01 metamaskbot

@metamaskbot update-policies

jiexi avatar Jan 31 '24 21:01 jiexi

Policies updated

metamaskbot avatar Jan 31 '24 21:01 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (jl/transaction-multichain-preview-test@47ed1ba). Click here to learn what that means.

:exclamation: Current head 36691dc differs from pull request most recent head 1961485. Consider uploading reports for the commit 1961485 to get more accurate results

Additional details and impacted files 
@@                            Coverage Diff                            @@
##             jl/transaction-multichain-preview-test   #22758   +/-   ##
=========================================================================
  Coverage                                          ?   68.51%           
=========================================================================
  Files                                             ?     1088           
  Lines                                             ?    42928           
  Branches                                          ?    11417           
=========================================================================
  Hits                                              ?    29410           
  Misses                                            ?    13518           
  Partials                                          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 22:01 codecov[bot]

Builds ready [2d484bd]
Page Load Metrics (820 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951961182210
domContentLoaded11231732
load7479398205928
domInteractive11231732
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -79.14 KiB (-2.35%)
  • ui: 0 Bytes (0.00%)
  • common: 136.4 KiB (2.71%)

metamaskbot avatar Jan 31 '24 22:01 metamaskbot

Builds ready [579e9d1]
Page Load Metrics (824 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90141114147
domContentLoaded9321873
load7389988246230
domInteractive9321873
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -79.14 KiB (-2.35%)
  • ui: 0 Bytes (0.00%)
  • common: 136.4 KiB (2.71%)

metamaskbot avatar Feb 01 '24 19:02 metamaskbot

@metamaskbot update-policies

jiexi avatar Feb 15 '24 16:02 jiexi

Policies updated

metamaskbot avatar Feb 15 '24 16:02 metamaskbot

Builds ready [36691dc]
Page Load Metrics (1043 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1413722094722
domContentLoaded1092332412
load8401555104313766
domInteractive1092332412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -101.79 KiB (-3.00%)
  • ui: -807 Bytes (-0.01%)
  • common: 166.7 KiB (3.31%)

metamaskbot avatar Feb 15 '24 19:02 metamaskbot

Builds ready [e8f9b90]
Page Load Metrics (1044 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1132191782914
domContentLoaded1072282210
load835118810447938
domInteractive1072282210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -101.9 KiB (-3.00%)
  • ui: -807 Bytes (-0.01%)
  • common: 166.7 KiB (3.31%)

metamaskbot avatar Feb 15 '24 20:02 metamaskbot

Builds ready [7126b35]
Page Load Metrics (1655 ± 232 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1294642728340
domContentLoaded10107622813
load82725931655482232
domInteractive10107622813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -101.83 KiB (-3.00%)
  • ui: 2.01 KiB (0.03%)
  • common: 166.69 KiB (3.31%)

metamaskbot avatar Feb 16 '24 01:02 metamaskbot

Builds ready [784140d]
Page Load Metrics (1927 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1034071736833
domContentLoaded105829168
load16252427192720096
domInteractive105829168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -101.83 KiB (-3.00%)
  • ui: 2.01 KiB (0.03%)
  • common: 166.69 KiB (3.31%)

metamaskbot avatar Feb 20 '24 23:02 metamaskbot