metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Remove unused notifications, their messages, and images

Open HowardBraham opened this issue 1 year ago • 12 comments

Description

Continues the work that @legobeat was doing in #20703 and #21533

All old numbered notifications except 8, 20, and 24 were permanently turned off, but their code, their messages.json, and most importantly their images were still present in the Extension.

By removing all this, we reduce the size of the zipped Extension by 949kB, and the unzipped Extension by 1,852kB.

IMPORTANT: This is NOT well-tested from a QA perspective, and QA should do some good testing on it before we merge.

Related issues

Followup to: #20703 Followup to: #21533

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

HowardBraham avatar Jan 27 '24 05:01 HowardBraham

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jan 27 '24 05:01 github-actions[bot]

Builds ready [321dc85]
Page Load Metrics (780 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85131109115
domContentLoaded9261742
load7218997804321
domInteractive9261742
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -118 Bytes (-0.00%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Jan 27 '24 05:01 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0bd096) 68.47% compared to head (17137c7) 68.54%. Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22678      +/-   ##
===========================================
+ Coverage    68.47%   68.54%   +0.07%     
===========================================
  Files         1088     1088              
  Lines        42956    42900      -56     
  Branches     11436    11417      -19     
===========================================
- Hits         29410    29403       -7     
+ Misses       13546    13497      -49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 00:01 codecov[bot]

Builds ready [65b7d0b]
Page Load Metrics (823 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92157112199
domContentLoaded9231542
load727113382310148
domInteractive9231542
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -118 Bytes (-0.00%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Jan 30 '24 00:01 metamaskbot

Builds ready [6ef3df8]
Page Load Metrics (811 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96148114147
domContentLoaded10451884
load7339178114924
domInteractive10451884
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -118 Bytes (-0.00%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Jan 31 '24 18:01 metamaskbot

Manual test cases passed on Chrome 121.0.6167.139 and Firefox 122.0:

  • [x] Send native token MM
  • [x] Send native token dapp
  • [x] Check incoming transactions history is present in the Activity list
  • [x] Send ERC20 token MM
  • [x] Send ERC20 token dapp
  • [x] Send ERC721 MM
  • [x] Send ERC721 dapp
  • [x] Import ERC 20 MM
  • [x] Import ERC20 dapp
  • [x] Import ERC721 MM
  • [x] Import ERC721 dapp
  • [x] Import ERC1155 MM
  • [x] Import ERC1155 dapp
  • [x] Contract interaction flows
  • [x] Approve ERC20
  • [x] Approve ERC721
  • [x] Approve ERC1155
  • [x] Cancel transaction
  • [x] Speed up cancellation
  • [x] Speed up transaction
  • [x] Queue multiple transactions, cancel / speed up
  • [x] Custom nonce
  • [x] Token autodetect
  • [x] NFT autodetect
  • [x] Add / remove networks / custom networks
  • [x] Personal sign
  • [x] Sign typed data
  • [x] Sign typed data v3
  • [x] Sign typed data v4
  • [x] Swap
  • [x] Smart swap

sleepytanya avatar Feb 03 '24 00:02 sleepytanya

  1. 'Watch NFT' and 'Watch all NFTs' is not responsive in Chrome, works as expected on Firefox.
  2. ENS name resolution on Chrome and Firefox: doesn't work on Linea Goerli and Sepolia lineaGoerliEns works on Goerli goerliEns On mainnet ENS name is initially recognized then 'ens lookup failed' message pops up

https://github.com/MetaMask/metamask-extension/assets/104780023/27166438-27ca-4a31-882d-3ad7251e2904

  1. Errors in the background when cancelling a swap: Firefox

https://github.com/MetaMask/metamask-extension/assets/104780023/5e05a727-798b-4002-af20-348fce93ee2e

Chrome Screenshot 2024-02-02 at 8 34 44 PM I wasn't able to cancel any swap (performed about 10 swaps).

sleepytanya avatar Feb 03 '24 01:02 sleepytanya

Builds ready [32113b5]
Page Load Metrics (755 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90130108105
domContentLoaded9351752
load7078267553115
domInteractive9341752
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 03 '24 09:02 metamaskbot

Builds ready [d2954e9]
Page Load Metrics (791 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84150113178
domContentLoaded95623147
load7229097915426
domInteractive95623147
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 06 '24 19:02 metamaskbot

Builds ready [c62f986]
Page Load Metrics (707 ± 12 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7412289115
domContentLoaded9171421
load6727517072412
domInteractive9171421
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 08 '24 01:02 metamaskbot

Builds ready [b02ec91]
Page Load Metrics (763 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7913796157
domContentLoaded9211442
load7128457633617
domInteractive9211442
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 09 '24 11:02 metamaskbot

Builds ready [b1d94c3]
Page Load Metrics (810 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint812761134421
domContentLoaded9197274019
load71410548106732
domInteractive9197274019
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 09 '24 21:02 metamaskbot

Builds ready [e6f0390]
Page Load Metrics (1105 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942211673617
domContentLoaded9142353215
load8501572110517785
domInteractive9142353215
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 12 '24 23:02 metamaskbot

I did some exploratory testing for notifications and compared the notifications between the PR branch and the develop branch. QA passed. ✔️ @HowardBraham

chloeYue avatar Feb 13 '24 10:02 chloeYue

Builds ready [17137c7]
Page Load Metrics (1030 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1162951894421
domContentLoaded986302411
load81618191030228109
domInteractive986302411
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: -14.19 KiB (-0.28%)

metamaskbot avatar Feb 13 '24 18:02 metamaskbot