metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Version v11.10.0

Open chloeYue opened this issue 1 year ago • 22 comments

Description

RC v11.10.0

chloeYue avatar Jan 25 '24 17:01 chloeYue

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jan 25 '24 17:01 github-actions[bot]

Builds ready [9785d8a]
Page Load Metrics (775 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89136108115
domContentLoaded9311642
load7038467753919
domInteractive9301642
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 25 '24 17:01 metamaskbot

v11.10.0 bug report: https://github.com/MetaMask/MetaMask-planning/issues/1970

chloeYue avatar Jan 26 '24 09:01 chloeYue

Manual test scenarios:

Chrome

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [x] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [ ] Tokens - import ERC721 token origin MM - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC721 token origin dapp - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC1155 token origin MM - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC1155 token origin dapp - https://github.com/MetaMask/metamask-extension/issues/22796
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [ ] Tokens - autodetect NFTs - https://github.com/MetaMask/metamask-extension/issues/22798
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [x] Address-book - add a contact to the address book
  • [x] Address-book - remove a contact from the address book
  • [x] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - eth sign
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token

Firefox

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [x] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [ ] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [ ] Tokens - import ERC721 token origin MM - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC721 token origin dapp - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC1155 token origin MM - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - import ERC1155 token origin dapp - https://github.com/MetaMask/metamask-extension/issues/22796
  • [ ] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [x] Tokens - autodetect NFTs - https://github.com/MetaMask/metamask-extension/issues/22798
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [x] Address-book - add a contact to the address book
  • [x] Address-book - remove a contact from the address book
  • [x] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - eth sign
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token

benjisclowder avatar Jan 26 '24 13:01 benjisclowder

the cancel txn functionality worked but not sure if its intended to show a "receive" for the cancel txn? Probably could handle this better but not sure (chrome) Screenshot 2024-01-31 at 3 58 01 PM

AlexHerman1 avatar Jan 31 '24 20:01 AlexHerman1

when testing the "send erc721 origin MM" scenario, it passed just fine, but i sent it to another account in this MM instance and the receiving account erroneously refers to the NFT as "Previously Owned" And does not allow you to send it, even after lock and unlock.

(chrome)

Screenshot 2024-01-31 at 4 31 58 PM Screenshot 2024-01-31 at 4 32 06 PM

AlexHerman1 avatar Jan 31 '24 21:01 AlexHerman1

chrome failed: Tokens - import ERC721 token origin MM

chrome failed: Tokens - import ERC1155 token origin MM

both show the same failure

Screenshot 2024-02-01 at 11 12 24 AM

Screenshot 2024-02-01 at 11 11 41 AM

AlexHerman1 avatar Jan 31 '24 22:01 AlexHerman1

autodetect NFT on mainnet not working with this asset:

https://etherscan.io/token/0xeda7b44eda773c69aeff616767d3b2e439cdb2fc?a=0xC8bc4288c81f18Cdbb1af2bA90863f4e8fe41Ea0

Also wont let me manually import

Screenshot 2024-02-01 at 11 10 05 AM

AlexHerman1 avatar Jan 31 '24 23:01 AlexHerman1

Release tracker for change validation on v11.10.0: https://docs.google.com/spreadsheets/d/1tsoodlAlyvEUpkkcNcbZ4PM9HuC9cEM80RZeoVv5OCQ/edit#gid=854571266

We need teams' approval on 7 Feb at the latest.

  • [x] Snaps: @bowensanders / @FrederikBolding / @Montoya - There are 2 Snaps changes in v11.10.0.
  • [x] Confirmation UX: @seaona - There are 7 Confirmations UX changes in v11.10.0.
  • [x] Confirmation Systems: @sleepytanya - There is 1 Confirmation Systems change in v11.10.0.
  • [x] Accounts: @plasmacorral - There are 4 Accounts changes in v11.10.0.
  • [ ] Assets: @sahar-fehri / @alfeng6 - There is 1 Assets changes in v11.10.0.
  • [x] Swaps: @davibroc / @dan437 - There is 1 Swaps change in v11.10.0.
  • [x] Extension UX: @darkwing / @NidhiKJha - There are 5 Extension UX changes in v11.10.0.
  • [ ] MMI: @zone-live / @shane-t - There is 1 MMI changes in v11.10.0.

Note: please attach all the release bugs to this bug report epic here: https://github.com/MetaMask/MetaMask-planning/issues/1970

Thank you so much!

chloeYue avatar Feb 01 '24 13:02 chloeYue

Firefox - v.11.10.0 Sign - eth sign Sign - personal sign Sign - sign in with ethereum Sign - sign typed with data

When signing the above type transactions, these error pop up after the pop-up closes. image

anaamolnar avatar Feb 01 '24 16:02 anaamolnar

Firefox - v.11.10.0 ENS - not supported on Sepolia, works fine on Mainnet, Goerli

anaamolnar avatar Feb 01 '24 16:02 anaamolnar

Firefox - v.11.10.0

Import ERC 712 origin Dapp - Watch NFT button does not prompt any transaction in the wallet Import ERC 712 origin Metamask - Importing the NFT manually results in this error image

Import ERC 1155 origin Dapp - Watch NFT button does not prompt any transaction in the wallet Import ERC 1155 origin Metamask - Importing the NFT manually results in this error image

anaamolnar avatar Feb 01 '24 20:02 anaamolnar

the cancel txn functionality worked but not sure if its intended to show a "receive" for the cancel txn? Probably could handle this better but not sure (chrome) Screenshot 2024-01-31 at 3 58 01 PM

@AlexHerman1 The "receive" post canceled transaction is expected as per the documentation of the test scenario.

benjisclowder avatar Feb 02 '24 14:02 benjisclowder

when testing the "send erc721 origin MM" scenario, it passed just fine, but i sent it to another account in this MM instance and the receiving account erroneously refers to the NFT as "Previously Owned" And does not allow you to send it, even after lock and unlock.

(chrome)

Screenshot 2024-01-31 at 4 31 58 PM Screenshot 2024-01-31 at 4 32 06 PM

Thanks @AlexHerman1, that's a good catch, I have checked and it was not happening in a previous version so it must have been introduced in this RC. I have logged it here: https://github.com/MetaMask/metamask-extension/issues/22794. What I noticed is that the NFT will appear on all accounts (even 4) that are added in the wallet, even before proceeding to send the asset. After sending it, the same mention is displayed on all accounts of "previously owned". As you said, lock/unlock does not do the trick, but Adding a new account does make it go away.

benjisclowder avatar Feb 02 '24 15:02 benjisclowder

chrome failed: Tokens - import ERC721 token origin MM

chrome failed: Tokens - import ERC1155 token origin MM

both show the same failure

Screenshot 2024-02-01 at 11 12 24 AM

Screenshot 2024-02-01 at 11 11 41 AM

That's valid, issue logged here: https://github.com/MetaMask/metamask-extension/issues/22796

benjisclowder avatar Feb 02 '24 15:02 benjisclowder

Firefox - v.11.10.0 Sign - eth sign Sign - personal sign Sign - sign in with ethereum Sign - sign typed with data

When signing the above type transactions, these error pop up after the pop-up closes. image

Hey @anaamolnar, I was not able to reproduce this for any of those sign transactions, was it consistent for you? Could you please record the steps and send me the recording?

benjisclowder avatar Feb 02 '24 15:02 benjisclowder

ENS on mainnet - initially works then 'ens lookup failed' message pops up. Chrome:

https://github.com/MetaMask/metamask-extension/assets/104780023/c4730a6d-d135-41f0-9112-34bd9687b9eb

Firefox:

https://github.com/MetaMask/metamask-extension/assets/104780023/222d988a-5fca-4ba7-8c47-c6169a1e19dc

sleepytanya avatar Feb 03 '24 02:02 sleepytanya

Builds ready [4c90ff7]
Page Load Metrics (758 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93128107115
domContentLoaded9271452
load7028267583517
domInteractive9271452
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 07 '24 12:02 metamaskbot

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/@tootallnate/[email protected]
New author npm/@metamask/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
New author npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/@metamask/[email protected]
New author npm/[email protected]

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Feb 07 '24 16:02 socket-security[bot]

🟢 QA Sign Off from Accounts team Several observations added to the bug report, but none are launch blocking.

plasmacorral avatar Feb 07 '24 17:02 plasmacorral

🟢 QA Sign Off from Confirmations System team

sleepytanya avatar Feb 08 '24 13:02 sleepytanya

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@graphql-tools/[email protected] Transitive: environment +3 2.71 MB ardatan
npm/@graphql-tools/[email protected] Transitive: environment +5 2.81 MB ardatan
npm/@graphql-tools/[email protected] Transitive: environment +2 2.69 MB ardatan
npm/@httptoolkit/[email protected] Transitive: environment, eval, filesystem +6 2.55 MB pimterry
npm/@metamask/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +226 50.3 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, eval, network +89 10.7 MB lgbot
npm/@metamask/[email protected] Transitive: environment, eval, filesystem +13 6.05 MB lgbot
npm/@metamask/[email protected] None +2 354 kB lgbot
npm/@metamask/[email protected] None +8 1.53 MB lgbot
npm/@metamask/[email protected] Transitive: network +1 192 kB lgbot
npm/@metamask/[email protected] None +5 370 kB metamaskbot
npm/@metamask/[email protected] None +4 524 kB lgbot
npm/@metamask/[email protected] Transitive: environment, eval, filesystem, network +26 9.65 MB lgbot
npm/@metamask/[email protected] Transitive: environment, eval, filesystem, network +136 34.2 MB metamaskbot
npm/@metamask/[email protected] network Transitive: environment, eval, filesystem +137 34.1 MB metamaskbot
npm/@tootallnate/[email protected] filesystem, network 0 1.73 MB tootallnate
npm/@types/[email protected] None 0 2.75 kB types
npm/[email protected] None 0 38.2 kB kasperisager
npm/[email protected] filesystem, network 0 136 kB patrickjuchli
npm/[email protected] None 0 4.98 kB isaacs
npm/[email protected] filesystem +1 4.38 MB harrisiirak
npm/[email protected] None 0 16.8 kB tootallnate
npm/[email protected] None +6 1.86 MB tootallnate
npm/[email protected] None +2 3.98 MB pimterry
npm/[email protected] None 0 27 kB damonoehlman
npm/[email protected] Transitive: environment, eval, filesystem, network +27 9.66 MB lgbot
npm/[email protected] None +1 130 kB amitgupta
npm/[email protected] filesystem, network Transitive: environment +6 297 kB tootallnate
npm/[email protected] network Transitive: environment +1 2.52 MB enisdenjo
npm/[email protected] network +2 89.2 kB szmarczak
npm/[email protected] None 0 81.8 kB acubed
npm/[email protected] filesystem, network Transitive: environment, eval, unsafe +152 28.6 MB pimterry
npm/[email protected] network Transitive: environment, filesystem +23 4.59 MB tootallnate
npm/[email protected] network +8 1.95 MB tootallnate
npm/[email protected] None 0 27.6 kB imazzara
npm/[email protected] filesystem, network +3 1.49 MB eriktrom
npm/[email protected] None +2 4.01 MB pimterry
npm/[email protected] None 0 25.2 kB matteo.collina
npm/[email protected] None +2 56.4 kB mafintosh
npm/[email protected] None 0 28.5 kB yaacovcr
npm/[email protected] network 0 137 kB pwnall

🚮 Removed packages: npm/@ardatan/[email protected], npm/@endo/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@httptoolkit/[email protected], npm/@httptoolkit/[email protected], npm/@httptoolkit/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@trufflesuite/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Feb 16 '24 18:02 socket-security[bot]

Builds ready [c2d8a9b]
Page Load Metrics (778 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88135109126
domContentLoaded10231632
load7008667783919
domInteractive10231632

metamaskbot avatar Feb 16 '24 19:02 metamaskbot

Builds ready [dcaec4d]
Page Load Metrics (780 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92130108115
domContentLoaded10281642
load7339957805828
domInteractive9281642

metamaskbot avatar Feb 16 '24 23:02 metamaskbot