metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Hackathon project: Codespaces

Open HowardBraham opened this issue 1 year ago • 31 comments

Description

A MetaMask development environment that's entirely in the browser.

You can try it right now by clicking on this button: Open in GitHub Codespaces

Right-click on the VNC desktop to launch Chrome or Firefox with MetaMask pre-installed.

USE CASES

  • Review a PR without stopping what you’re working on
  • Develop on a Chromebook or iPad
  • Repro a flaky test that's only flaky on CircleCI, not locally
  • Get up and running quickly as a new external contributor / team member
  • Give a programming test for candidates
  • Allow PM to easily test a branch

Must do before merging

  • [x] Get alignment within the business about security and cost implications https://consensys.slack.com/archives/GV90KPED9/p1707881094230659
  • [x] Review install.sh

Related issues

Manual testing steps

Screenshots/Recordings

quick

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

HowardBraham avatar Dec 20 '23 16:12 HowardBraham

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 20 '23 16:12 github-actions[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@esbuild/[email protected] None 0 10.4 MB evanw
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +27 224 MB hirokiosame

View full report↗︎

socket-security[bot] avatar Dec 20 '23 16:12 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Dec 20 '23 16:12 socket-security[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7107841) 68.48% compared to head (e52edc6) 68.48%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22358   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1089     1089           
  Lines        43015    43015           
  Branches     11462    11462           
========================================
  Hits         29455    29455           
  Misses       13560    13560

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 20 '23 16:12 codecov[bot]

Builds ready [dd0c237]
Page Load Metrics (1366 ± 148 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint933291606833
domContentLoaded8195465828
load84418721366309148
domInteractive8195465828
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 20 '23 17:12 metamaskbot

this is super cool

danjm avatar Dec 20 '23 17:12 danjm

Builds ready [4c8c184]
Page Load Metrics (1212 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint843291968340
domContentLoaded9212878239
load83818561212332159
domInteractive9212878239
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 20 '23 20:12 metamaskbot

Builds ready [f32b7e6]
Page Load Metrics (1381 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963242067235
domContentLoaded9211757737
load97118531381313150
domInteractive9211757737
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 20 '23 21:12 metamaskbot

Builds ready [387f88b]
Page Load Metrics (1136 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882901737335
domContentLoaded9211827838
load78217191136252121
domInteractive9211827838
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 21 '23 00:12 metamaskbot

Builds ready [35cbf2e]
Page Load Metrics (1163 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint863101837636
domContentLoaded9195807837
load78617561163266128
domInteractive9195807837
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 21 '23 12:12 metamaskbot

Builds ready [3b86165]
Page Load Metrics (1115 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint812781215125
domContentLoaded8180294722
load7711339111518488
domInteractive8180294722
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 21 '23 21:12 metamaskbot

Builds ready [a16956f]
Page Load Metrics (1280 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882871626632
domContentLoaded9196587234
load83916761280254122
domInteractive9196587234
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 21 '23 21:12 metamaskbot

Builds ready [f8435d7]
Page Load Metrics (1365 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963432197234
domContentLoaded11224927837
load101719701365315151
domInteractive11223927837
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 12 '24 10:01 metamaskbot

Builds ready [2a1fbbf]
Page Load Metrics (1167 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint893031807737
domContentLoaded9217828239
load81416241167253121
domInteractive9217828239
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 13 '24 00:01 metamaskbot

Builds ready [ba48826]
Page Load Metrics (1207 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892591476230
domContentLoaded8180446129
load81918191207245118
domInteractive8180446129
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 13 '24 01:01 metamaskbot

Builds ready [4c062ac]
Page Load Metrics (1357 ± 129 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint973361627636
domContentLoaded9211486632
load96217971357269129
domInteractive9211486632
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 22 '24 19:01 metamaskbot

Builds ready [45ba808]
Page Load Metrics (845 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint109157125136
domContentLoaded105322126
load7509388455727
domInteractive105322126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 26 '24 06:01 metamaskbot

Builds ready [c34193b]
Page Load Metrics (745 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9112210584
domContentLoaded9231532
load7017977452813
domInteractive9231532
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jan 30 '24 03:01 metamaskbot

Builds ready [f7d96f7]
Page Load Metrics (859 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94156119178
domContentLoaded86420136
load716163885919192
domInteractive86420136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 01 '24 23:02 metamaskbot

Builds ready [646d0e9]
Page Load Metrics (742 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9011910374
domContentLoaded9211531
load6987977423115
domInteractive9211531
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 05 '24 18:02 metamaskbot

Builds ready [b0e231d]
Page Load Metrics (765 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84130105115
domContentLoaded9251542
load69510677657938
domInteractive9251542
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 05 '24 21:02 metamaskbot

Builds ready [2dae193]
Page Load Metrics (795 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint80146106157
domContentLoaded95619105
load7218647953818
domInteractive95619105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 08 '24 03:02 metamaskbot

Builds ready [7899de7]
Page Load Metrics (767 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8013597147
domContentLoaded9271663
load7168467673417
domInteractive9271663
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 09 '24 10:02 metamaskbot

Builds ready [ab10fd6]
Page Load Metrics (1045 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1213091975627
domContentLoaded9134433316
load7831405104514771
domInteractive9134423316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 13 '24 00:02 metamaskbot

Builds ready [930ba55]
Page Load Metrics (1084 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122491863617
domContentLoaded11109453014
load8031335108413364
domInteractive11109453014
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 13 '24 18:02 metamaskbot

@HowardBraham how goes the checklist of items we wanted to get done here before review/merge? Maybe we should enumerate those outstanding items in the PR description for clarity

brad-decker avatar Feb 14 '24 17:02 brad-decker

Builds ready [71e9c28]
Page Load Metrics (1123 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1003081945225
domContentLoaded10105382412
load8961376112316278
domInteractive10105382412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 19:02 metamaskbot

Builds ready [d078ad4]
Page Load Metrics (1014 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1053241884923
domContentLoaded878332512
load7991402101414168
domInteractive878332512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 02:02 metamaskbot

Builds ready [33a676b]
Page Load Metrics (1070 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1223721945024
domContentLoaded11100382713
load9001562107014670
domInteractive11100382713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 04:02 metamaskbot

Builds ready [24bcefc]
Page Load Metrics (1008 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122161753517
domContentLoaded985292412
load7371394100814067
domInteractive985292412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 16:02 metamaskbot