metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Increase token rates controller interval

Open danjm opened this issue 2 years ago • 5 comments

Description

This reduces the request load we put on coingecko

Related issues

Fixes: #

Manual testing steps

  1. Open metamask
  2. Import tokens
  3. See request to coingecko
  4. Leave background console open and wait 65 minutes, there should be 2 and only 2 more requests to coingecko

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

danjm avatar Dec 01 '23 10:12 danjm

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 01 '23 10:12 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10d40aa) 67.78% compared to head (ab1140b) 67.79%. Report is 301 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22120   +/-   ##
========================================
  Coverage    67.78%   67.79%           
========================================
  Files         1065     1065           
  Lines        41275    41272    -3     
  Branches     11066    11065    -1     
========================================
  Hits         27978    27978           
+ Misses       13297    13294    -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 13 '23 16:12 codecov[bot]

Builds ready [e5cd5b3]
Page Load Metrics (1294 ± 133 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922531284421
domContentLoaded9174304522
load82719101294276133
domInteractive9174304522
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 13 '23 16:12 metamaskbot

Builds ready [ab1140b]
Page Load Metrics (1176 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842641234823
domContentLoaded9182314923
load8531501117618187
domInteractive9182314923
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 13 '23 18:12 metamaskbot

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar Feb 11 '24 20:02 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar Feb 25 '24 22:02 github-actions[bot]