metamask-extension
metamask-extension copied to clipboard
Specify that Zora is a multilayer network
Explanation
Zora is also based on the OP stack, so follows the same gas rules as Optimism and Base. This closely follows the form of #20097.
Manual Testing Steps
- Open the extension
- Add the Zora network
- Send some transactions
Pre-merge author checklist
- [x] I've clearly explained:
- [x] What problem this PR is solving
- [x] How this problem was solved
- [x] How reviewers can test my changes
- [ ] Sufficient automated test coverage has been added
Pre-merge reviewer checklist
- [ ] Manual testing (e.g. pull and build branch, run in browser, test code being changed)
- [ ] PR is linked to the appropriate GitHub issue
- [ ] IF this PR fixes a bug in the release milestone, add this PR to the release milestone
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.
In this case, a QA Engineer approval will be be required.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I have read the CLA Document and I hereby sign the CLA
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
1e5578e) 68.57% compared to head (e6d9e3c) 68.67%.
:exclamation: Current head e6d9e3c differs from pull request most recent head 0261b60. Consider uploading reports for the commit 0261b60 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #20501 +/- ##
===========================================
+ Coverage 68.57% 68.67% +0.10%
===========================================
Files 1018 990 -28
Lines 40853 38384 -2469
Branches 10903 10309 -594
===========================================
- Hits 28014 26359 -1655
+ Misses 12839 12025 -814
| Files | Coverage Δ | |
|---|---|---|
| shared/constants/network.ts | 100.00% <ø> (ø) |
|
| ui/selectors/selectors.js | 86.55% <100.00%> (+0.32%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.
Hi @kolber, sorry for the delay in working through your PR. We'll get to it soon (expect ~2 weeks).
Hi @kolber, sorry for the delay in working through your PR. We'll get to it soon (expect ~2 weeks).
No problem at all! Thanks for the update. :)
Just an update: the team will be wrapping up a work this week that is currently blocking moving on to this. Sorry for the delay, but we're planning to get to this soon!
@bschorchit Just bumping this. We have users actively switching to other wallets due to inflated fees that result from this diff and it would be great to offer a consistent experience between wallets.
+1 on this!
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.