metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Fix Button Alignment of Send Button in Nft-Details

Open NidhiKJha opened this issue 1 year ago • 8 comments

Describe the bug

In the popup view, the send button is not properly aligned Screenshot 2023-07-17 at 4 09 42 PM

Steps to reproduce

  1. Go to the NFTs Tab
  2. Go to any NFT detail in the popup view

Error messages or log output

No response

Version

10.33.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

NidhiKJha avatar Jul 17 '23 10:07 NidhiKJha

Hey @NidhiKJha, can I work on this issue?

MukulKolpe avatar Jul 17 '23 16:07 MukulKolpe

Sure I have assigned it to you, thanks @MukulKolpe

NidhiKJha avatar Jul 17 '23 17:07 NidhiKJha

@NidhiKJha I would also like to work on this issue.

SakshiShah29 avatar Jul 18 '23 15:07 SakshiShah29

Hey @MukulKolpe, @ducksblock has a PR opened for this issue. Hence, I am assigning it to him. You can look for more good first issue here, Thanks!

NidhiKJha avatar Jul 25 '23 07:07 NidhiKJha

@NidhiKJha is this issue still open, I would love to contribute.

SamarthBagga avatar Sep 30 '23 17:09 SamarthBagga

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Dec 29 '23 18:12 github-actions[bot]

Would like to work on it. Please assign

harshbsharma avatar Jan 21 '24 13:01 harshbsharma

I've removed the team-design-system label since this issue is about the implementation of styles added to the button, rather than the button component itself. The recommended fix is to use the style utility array props to apply these styles only on large screens. Please reach out if you have any questions

Screenshot

georgewrmarshall avatar May 16 '24 22:05 georgewrmarshall

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Aug 15 '24 00:08 github-actions[bot]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

github-actions[bot] avatar Sep 29 '24 00:09 github-actions[bot]

Have a nice day 🥰🥰

Maliksb11 avatar Sep 29 '24 01:09 Maliksb11