metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: typo thai ui text

Open panapol-p opened this issue 1 year ago • 8 comments

Explanation

I found thai word is incorrect

Screenshots/Screencaps

image

สำเหร็จ -> สำเร็จ แอดแดรส -> แอดเดรส เเริ่ม -> เริ่ม แก็ส -> แก๊ส

Manual Testing Steps

N/A

Pre-merge author checklist

  • [x] I've clearly explained:
    • [x] What problem this PR is solving
    • [x] How this problem was solved
    • [ ] How reviewers can test my changes
  • [ ] Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • [ ] Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • [ ] PR is linked to the appropriate GitHub issue
  • [ ] IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

panapol-p avatar May 22 '23 19:05 panapol-p

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 22 '23 19:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

panapol-p avatar May 22 '23 19:05 panapol-p

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ed36028) 68.74% compared to head (e7b70c8) 68.86%.

:exclamation: Current head e7b70c8 differs from pull request most recent head afbf25e. Consider uploading reports for the commit afbf25e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19251      +/-   ##
===========================================
+ Coverage    68.74%   68.86%   +0.13%     
===========================================
  Files         1042      998      -44     
  Lines        41475    38949    -2526     
  Branches     11084    10468     -616     
===========================================
- Hits         28509    26822    -1687     
+ Misses       12966    12127     -839     

see 307 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 02 '23 09:08 codecov[bot]

Hi @vinistevam Could you pelase help to review this change.

panapol-p avatar Aug 27 '23 06:08 panapol-p

Hi @vinistevam Could you pelase help to review this change.

@panapol-p Thank you for your contribution and sorry for the hold-up. I've asked our translation team to assist with the review and I'll let you know as soon as they reply.

vinistevam avatar Aug 29 '23 09:08 vinistevam

@Unik0rnMaggie Thank you for the review. I have successfully updated the message krub.

panapol-p avatar Sep 02 '23 05:09 panapol-p

That is excellent @panapol-p ! Could you update your branch to fix the pipeline? :pray:

vinistevam avatar Sep 07 '23 11:09 vinistevam

Hi @vinistevam I have successfully updated this branch krub.

panapol-p avatar Sep 08 '23 03:09 panapol-p

Hi, @Unik0rnMaggie I've updated this branch with a rebase to address the issues related to the CI/CD test errors but it still error. Could you please review this PR again?

@vinistevam for this one ci/circleci: test-e2e-mmi-playwright - OPTIONAL can we ignore this optional test right?

panapol-p avatar Feb 29 '24 09:02 panapol-p