metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Review spending cap screen

Open filipsekulic opened this issue 2 years ago • 2 comments

Explanation

Created a new screen - 'Review Spending Cap' screen.

More Information

  • Fixes #15220

Screenshots/Screencaps

Before

https://user-images.githubusercontent.com/92310504/191487193-b08b626c-0b3f-4f82-a055-eebb54828e08.mov

After

https://user-images.githubusercontent.com/92310504/191487280-373e2ae3-141e-4bc1-89e5-fe66f83292d9.mov

Manual Testing Steps

BEFORE TESTING - in your .metamaskrc file, set TOKEN_ALLOWANCE_IMPROVEMENTS=1 and then start the app

  1. Open the Test Dapp: https://metamask.github.io/test-dapp/
  2. Under the section Send Tokens click on CREATE TOKEN
  3. Wait for the token to be created and then, under the same section, click on APPROVE TOKENS or APPROVE TOKENS WITHOUT GAS in order to see the newly created screen

To see how the screen looks like when the enhanced gas fee is enabled, go to Settings (Experimental tab) and enable it (Enable enhanced gas fee UI toggle).

filipsekulic avatar Sep 21 '22 11:09 filipsekulic

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 21 '22 11:09 github-actions[bot]

Builds ready [e49ab08]
Page Load Metrics (1437 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881579260416200
domContentLoaded11691823142219192
load11691855143718689
domInteractive11691823142219192

highlights:

storybook

metamaskbot avatar Sep 21 '22 12:09 metamaskbot

Builds ready [d90bade]
Page Load Metrics (2179 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint941887197388186
domContentLoaded18412458216016077
load18412458217916177
domInteractive18412458216016077

highlights:

storybook

metamaskbot avatar Sep 23 '22 12:09 metamaskbot

Builds ready [4d8ce74]
Page Load Metrics (2650 ± 191 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint983130456887426
domContentLoaded207931782641407195
load210031962650398191
domInteractive207931782641407195

highlights:

storybook

metamaskbot avatar Sep 27 '22 08:09 metamaskbot

Verified by QA

mirjanaKukic avatar Sep 27 '22 13:09 mirjanaKukic

Builds ready [d588c5e]
Page Load Metrics (2540 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91152119178
domContentLoaded221529552519224107
load221529822540230110
domInteractive221529552519224107

highlights:

storybook

metamaskbot avatar Sep 27 '22 13:09 metamaskbot

Builds ready [6c593ba]
Page Load Metrics (2481 ± 209 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882141323115
domContentLoaded186435532460434208
load193735532481435209
domInteractive186435532460434208

highlights:

storybook

metamaskbot avatar Sep 28 '22 09:09 metamaskbot

Hey @georgewrmarshall! Good catch! :raised_hands: I fixed everything you mentioned except two things that I suppose were there before. I am not sure why on your computer it opens up the app in the full-screen view. You can check the attached video and see that on my computer it works fine. Also, I would like to mention that one of my colleagues has the same issue as you in different scenarios. He firstly saw this issue before this PR was created. Regarding the opening link in a new tab from the full-screen view, you can also check it from the attached video. There you can see that this issue is existing and was there before. I suppose it can be fixed somehow by changing the Button component that is being used throughout the app.

https://user-images.githubusercontent.com/92310504/193084350-0f102626-15ab-43b4-9c25-b06786685518.mov

filipsekulic avatar Sep 29 '22 16:09 filipsekulic

Builds ready [6ce3438]
Page Load Metrics (2359 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912410252498239
domContentLoaded193229102352260125
load193229262359267128
domInteractive193229102352260125

highlights:

storybook

metamaskbot avatar Sep 29 '22 17:09 metamaskbot

Builds ready [984fdfb]
Page Load Metrics (2225 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint86139104146
domContentLoaded19412524219614067
load20042643222514971
domInteractive19412524219614067

highlights:

storybook

metamaskbot avatar Oct 04 '22 08:10 metamaskbot

It would be nice to have stories for approve content card now, but not a blocker.

I'll then add the missing storybook in the following PR where this token allowance improvements feature will be fully completed.

filipsekulic avatar Oct 05 '22 15:10 filipsekulic

Builds ready [7382be0]
Page Load Metrics (2210 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89138105136
domContentLoaded18992507219714168
load18992594221015172
domInteractive18992507219714168

highlights:

storybook

metamaskbot avatar Oct 05 '22 15:10 metamaskbot