metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Update address component on transaction data screen

Open amerkadicE opened this issue 2 years ago • 2 comments

Explanation

This pull request will update the current logic for a recipient address on the transaction data screen. Now it will show

  1. If the address exists in the user account list, then the account name is displayed
  2. If the address exists in the user address book (contacts), then their nickname is displayed
  3. If the address exists in the contract metadata list, then the contract's name is displayed
  4. If conditionals from before are not met, it will show the user address.

Also, clicking on this component opens the 'add/edit nickname' popup or this tooltip if it's one of the user's accounts.

After checking the code, we found out that this PR will also update the logic on the recipient address when sending funds as shown in screenshot below.

More Information

Fixes #15780

Screenshots/Screencaps

Before

image

After

image image

Send screen image

Manual Testing Steps

Pre-Merge Checklist

  • [x] PR template is filled out
  • [x] IF this PR fixes a bug, a test that would have caught the bug has been added
  • [x] PR is linked to the appropriate GitHub issue
  • [ ] PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • [ ] Manual testing complete & passed
  • [ ] "Extension QA Board" label has been applied

amerkadicE avatar Sep 20 '22 12:09 amerkadicE

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 20 '22 12:09 github-actions[bot]

Builds ready [36914f0]
Page Load Metrics (1324 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902441113216
domContentLoaded11681721131614469
load11681721132414168
domInteractive11681720131614469

highlights:

storybook

metamaskbot avatar Sep 21 '22 09:09 metamaskbot

Builds ready [9ce516c]
Page Load Metrics (1360 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911272167254122
domContentLoaded1214155113459144
load1214155113609847
domInteractive1214155113459144

highlights:

storybook

metamaskbot avatar Sep 22 '22 12:09 metamaskbot

Builds ready [678bdad]
Page Load Metrics (1261 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint851310227349168
domContentLoaded1135144012528139
load1135146812618842
domInteractive1135144012528139

highlights:

storybook

metamaskbot avatar Sep 23 '22 14:09 metamaskbot

Verified by QA

mirjanaKukic avatar Sep 26 '22 11:09 mirjanaKukic

Builds ready [74bd53f]
Page Load Metrics (2271 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint952307416737354
domContentLoaded18362517223915675
load19412646227115374
domInteractive18362517223915675

highlights:

storybook

metamaskbot avatar Nov 07 '22 19:11 metamaskbot