[Bug]: Settings Search does not find manually added Custom Networks

[seaona]

Describe the bug

Problem: after adding some Custom Networks, if I want to search them on the Settings Search bar I can see that they are not found.

search-not-update.webm

Steps to reproduce

1. Enable Custom Network List from Experimental Settings
2. Add a custom network
3. Search for that network name on the Settings search bar

Error messages or log output

No response

Version

10.19.0

Build type

No response

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

[danjm]

@seaona Did we ever support this functionality? Or was this a stated requirement somewhere?

[seaona]

@danjm just checked on previous versions and indeed seems it was never supported to extend the search to "new items" on the state. Should I close the issue or is it something that we should expect within the Search func? Haven't seen any requirement specific for that though

[bschorchit]

I don't think we ever stated it anywhere, but I could see why it would be a user expectation as default networks can be found this way. Labelled this as an ux-papercut.

[ElvirCe]

@seaona @bschorchit @danjm the very top search field is meant to be used to search for settings and the one below the "Settings" title is for networks search. I tried both and in the one below that is meant for networks forks fine and displays all networks. Should we still proceed and also make changes to the settings search? If yes, I am thinking then the search bar below "Settings" is maybe redundant and we can remove it totally.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days. Thank you for your contributions.

[github-actions[bot]]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.