metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Fix deploying the TS migration dashboard

Open mcmire opened this issue 3 years ago • 2 comments

Explanation

When the TypeScript migration dashboard is updated, it is built and deployed in another repo, which is then deployed via GitHub Pages. To push to this repo we have to set a Git username and email. This is missing from the CircleCI config, so this commit uses the metamaskbot GitHub account to do that.

More Information

See the PR introducing the TypeScript migration dashboard for more context.

Also see Storybook, which takes a similar approach.

Manual Testing Steps

There isn't anything to test here, but the job-publish-ts-migration-dashboard step in CircleCI should not fail. This step will only get run when this PR is merged, so a subsequent PR will be needed if this one doesn't fix it.

Pre-Merge Checklist

  • [ ] PR template is filled out
  • [ ] IF this PR fixes a bug, a test that would have caught the bug has been added
  • [ ] PR is linked to the appropriate GitHub issue
  • [ ] PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • [ ] Manual testing complete & passed
  • [ ] "Extension QA Board" label has been applied

mcmire avatar Aug 09 '22 21:08 mcmire

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 09 '22 21:08 github-actions[bot]

Builds ready [8037531]
Page Load Metrics (1812 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871896199389187
domContentLoaded16492122178912761
load16492122181212661
domInteractive16492122178912761

metamaskbot avatar Aug 09 '22 21:08 metamaskbot