[Bug]: A transferFrom operation is displayed as a Send from the caller address
Describe the bug
Problem: when I am performing a transferFrom operation, I can see that MetaMask displays this as a regular Send from the address that is calling the operation to the recipient.
This could be mis-leading, as the transfer is being performed from the selected address I choose, instead of the caller address.
https://user-images.githubusercontent.com/54408225/183687421-aab45ec8-3928-4451-aa21-b7b98917107f.mp4
Steps to reproduce
- Select Rinkeby network
- Import LINK tokens from Etherscan
- Ask for some LINK tokens on the faucet
- Go to Write contract tab on Etherscan
- Connect MM
- Perform an Approve tx and introduce an address you are granting permissions and amount
- Change to the address in step 6
- Refresh Etherscan
- Re-connect MM
- Click transferFrom and select initial address, to another address and the granted amount
- Proceed and see MM pop-up displays a rgular send and check tx details
Error messages or log output
No response
Version
10.19.0
Build type
No response
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
This is an interesting issue! I think it's correct though that we show the caller address because this is indeed the account who will be signing and submitting the transaction, right?
I can see why this could cause confusion as you mentioned and we should definitely think of how we could make it easier to understand, but I don't think it's a bug. If you agree, I'll switch the label from bug to feature request (I've already added to one of transactions epics so we keep it on our radar).