metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[Bug]: A transferFrom operation is displayed as a Send from the caller address

Open seaona opened this issue 3 years ago • 0 comments

Describe the bug

Problem: when I am performing a transferFrom operation, I can see that MetaMask displays this as a regular Send from the address that is calling the operation to the recipient. This could be mis-leading, as the transfer is being performed from the selected address I choose, instead of the caller address.

https://user-images.githubusercontent.com/54408225/183687421-aab45ec8-3928-4451-aa21-b7b98917107f.mp4

Steps to reproduce

  1. Select Rinkeby network
  2. Import LINK tokens from Etherscan
  3. Ask for some LINK tokens on the faucet
  4. Go to Write contract tab on Etherscan
  5. Connect MM
  6. Perform an Approve tx and introduce an address you are granting permissions and amount
  7. Change to the address in step 6
  8. Refresh Etherscan
  9. Re-connect MM
  10. Click transferFrom and select initial address, to another address and the granted amount
  11. Proceed and see MM pop-up displays a rgular send and check tx details

Error messages or log output

No response

Version

10.19.0

Build type

No response

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

seaona avatar Aug 09 '22 15:08 seaona

This is an interesting issue! I think it's correct though that we show the caller address because this is indeed the account who will be signing and submitting the transaction, right?

I can see why this could cause confusion as you mentioned and we should definitely think of how we could make it easier to understand, but I don't think it's a bug. If you agree, I'll switch the label from bug to feature request (I've already added to one of transactions epics so we keep it on our radar).

bschorchit avatar Aug 18 '22 22:08 bschorchit