metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

set ens name

Open brad-decker opened this issue 2 years ago • 1 comments

Explanation

A further explanation will be added but in the meantime I stumbled upon #11373 from @hsy822. This was a great contribution by a contributor who had made several pull requests in a short period of time. I provided feedback but ultimately this got lost in the shuffle of our PR queue. The branch on @hsy822 's fork was deleted, so I pulled the ref using gh cli and pushed it to a new branch after resolving conflicts and updating. This will likely fail tests but i'll be seeing this through to merge. Thank you @hsy822! your original attribution will remain intact once this pr lands.

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • [ ] PR template is filled out
  • [ ] IF this PR fixes a bug, a test that would have caught the bug has been added
  • [ ] PR is linked to the appropriate GitHub issue
  • [ ] PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • [ ] Manual testing complete & passed
  • [ ] "Extension QA Board" label has been applied

brad-decker avatar Aug 05 '22 15:08 brad-decker

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 05 '22 15:08 github-actions[bot]