metamask-extension Skip searching 4byte directory if we don't have a full 4 bytes of data

We should only query 4byte.directory if we have a full 4bytes of data in hex-string form to query against. 4byte.directory will return an unfiltered list of signatures without a full valid query: https://www.4byte.directory/api/v1/signatures/?hex_signature=0x0. Discovered as part of this thread.

Before: https://user-images.githubusercontent.com/34557516/182933602-1b3925e9-4e88-40f8-a2d9-566c1f56a2a0.mp4

https://user-images.githubusercontent.com/34557516/182933715-b29ed147-251b-4344-a6ce-b68ebd184583.mp4

After: https://user-images.githubusercontent.com/34557516/182933915-b5854ed7-2c4f-4b38-8586-99fd797fd6e9.mov

Aug 04 '22 19:08 adonesky1

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Aug 04 '22 19:08 github-actions[bot]

from QA looks good

Aug 05 '22 10:08 seaona

Builds ready [d8e4868]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1685 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	147	107	17	8
		domContentLoaded	1551	1891	1660	84	40
		load	1563	1910	1685	91	44
		domInteractive	1551	1891	1660	84	40

highlights:

storybook

Aug 08 '22 19:08 metamaskbot

Builds ready [eaec140]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1401 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	149	117	16	8
		domContentLoaded	1227	1984	1382	200	96
		load	1227	1984	1401	197	95
		domInteractive	1227	1984	1382	200	96

highlights:

storybook

Sep 14 '22 17:09 metamaskbot

Just saw this other issue related to resolving contract functions. It seems it's a different one, but not sure if this PR would also affect this behaviour. Just tagging FYI @adonesky1 @digiwand

Zero-arg function calls shown as "Contract interaction" rather than function name

Sep 15 '22 13:09 seaona

metamask-extension metamask-extension copied to clipboard

Skip searching 4byte directory if we don't have a full 4 bytes of data

highlights:

highlights:

metamask-extension
metamask-extension copied to clipboard