metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

[WIP]: Remove related UI code from the app dir

Open filipsekulic opened this issue 2 years ago • 2 comments

Explanation

Removed all the ui references within the app directory. Moved those references into the app directory (app/constants/*.js and other files - see the code) so they are now being imported from that place in both the ui and app directory in order to prevent redundancy.

More Information

Fixes: https://github.com/MetaMask/metamask-extension/issues/15286

  • Relates to: #15023

TO DO

  • Fix failing unit tests
  • Fix jest coverage

filipsekulic avatar Jul 29 '22 13:07 filipsekulic

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 29 '22 13:07 github-actions[bot]

A lot of changes are lint related. I am not sure what has changed recently with lint configuration.

jpuri avatar Aug 10 '22 06:08 jpuri

Work done so far.

I have removed all the UI related code in constant and moved them to shared/ folder. The rationale for this is that the code are being used by both App and UI, so should be in shared folder.

I also fixed unit tests accordingly and e2e tests as well.

To make rebase easier, I also squashed all the commits before rebasing....Although I can see the branch is out of sync again and will need another rebase. But this should be easy since the commits are squashed.

Unit tests are currently failing because of tests threshold, which basically means we need to write more tests.

segun avatar Aug 22 '22 15:08 segun

Builds ready [978120d]
Page Load Metrics (1771 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912031192613
domContentLoaded15542117175112259
load15542117177113766
domInteractive15542117175112259

highlights:

storybook

metamaskbot avatar Aug 26 '22 10:08 metamaskbot

Verified by QA

mirjanaKukic avatar Aug 29 '22 11:08 mirjanaKukic

Builds ready [680f9ca]
Page Load Metrics (2327 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1162101572211
domContentLoaded190727092307232111
load190727222327238114
domInteractive190727092307232111

highlights:

storybook

metamaskbot avatar Sep 12 '22 16:09 metamaskbot

@filipsekulic gonna need a rebase here.

brad-decker avatar Sep 14 '22 18:09 brad-decker

@filipsekulic gonna need a rebase here.

Done :white_check_mark:

filipsekulic avatar Sep 15 '22 23:09 filipsekulic

Builds ready [de266ca]
Page Load Metrics (1260 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90139110157
domContentLoaded1135145012479345
load1135145112609043
domInteractive1135145012479345

highlights:

storybook

metamaskbot avatar Sep 15 '22 23:09 metamaskbot