metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

MV3: add retry logic to actions

Open jpuri opened this issue 2 years ago • 6 comments

Add retry logic to actions

jpuri avatar Jul 26 '22 12:07 jpuri

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 26 '22 12:07 github-actions[bot]

Progresses #14853

danjm avatar Jul 26 '22 16:07 danjm

Builds ready [f392964]
Page Load Metrics (1702 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85140107157
domContentLoaded15411978167710752
load1541197817029948
domInteractive15411978167710752

highlights:

storybook

metamaskbot avatar Aug 03 '22 16:08 metamaskbot

Builds ready [4d41431]
Page Load Metrics (1831 ± 266 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint822751154823
domContentLoaded149735031808538258
load149735031831554266
domInteractive149735031808537258

highlights:

storybook

metamaskbot avatar Aug 04 '22 13:08 metamaskbot

Currently when clearing the queue we run action asynchronously, but I am thinking may be we should do it synchronous as they are in sequence of user interaction. Consider user updating gas params on transaction twice - we need to ensure that they run in sequence.

jpuri avatar Aug 08 '22 13:08 jpuri

Currently when clearing the queue we run action asynchronously, but I am thinking may be we should do it synchronous as they are in sequence of user interaction. Consider user updating gas params on transaction twice - we need to ensure that they run in sequence.

I thought executing them quickly was a requirement. This makes implementation much nicer, may even help eliminate the need for the splice.

naugtur avatar Aug 09 '22 07:08 naugtur

Builds ready [acd5f2e]
Page Load Metrics (1820 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint873111144622
domContentLoaded16192094178610149
load16742094182010148
domInteractive16192094178610149

highlights:

storybook

metamaskbot avatar Aug 16 '22 13:08 metamaskbot

Builds ready [080cd36]
Page Load Metrics (2105 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98157129147
domContentLoaded17442565208718991
load17442566210518890
domInteractive17442565208718991

highlights:

storybook

metamaskbot avatar Aug 17 '22 16:08 metamaskbot

Builds ready [3b11f94]
Page Load Metrics (1741 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89155109168
domContentLoaded1595196717289345
load15951986174110450
domInteractive1594196717289345

highlights:

storybook

metamaskbot avatar Aug 22 '22 17:08 metamaskbot

Builds ready [0c19e3e]
Page Load Metrics (1828 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint931821232411
domContentLoaded16202367179918086
load16212367182817785
domInteractive16202367179918086

highlights:

storybook

metamaskbot avatar Aug 23 '22 06:08 metamaskbot

Is this a feature branch? Is the idea here that all those idempotent prs are gonna collect here? Could we add the PR template here and fill it out with as much detail as possible

brad-decker avatar Aug 23 '22 17:08 brad-decker

Is this a feature branch? Is the idea here that all those idempotent prs are gonna collect here? Could we add the PR template here and fill it out with as much detail as possible

Hey @brad-decker : the intend is not to make it feature branch, this is ready for merge. Other PRs are based on this as they need these changes to work.

jpuri avatar Aug 23 '22 18:08 jpuri

Builds ready [8161b91]
Page Load Metrics (1735 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97177119188
domContentLoaded1573197717099345
load15742104173511756
domInteractive1573197717099345

highlights:

storybook

metamaskbot avatar Aug 23 '22 20:08 metamaskbot

Builds ready [b67442c]
Page Load Metrics (1724 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint102153116147
domContentLoaded1587194716948943
load1591194717249546
domInteractive1587194716948943

highlights:

storybook

metamaskbot avatar Aug 24 '22 07:08 metamaskbot

Builds ready [678f4af]
Page Load Metrics (1878 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint993151334421
domContentLoaded16102127185212359
load16892127187812058
domInteractive16102127185212359

highlights:

storybook

metamaskbot avatar Aug 24 '22 16:08 metamaskbot

Builds ready [85c7075]
Page Load Metrics (1715 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901685191343165
domContentLoaded1629184916965928
load1639187217156029
domInteractive1629184916965928

highlights:

storybook

metamaskbot avatar Aug 25 '22 09:08 metamaskbot

Builds ready [650a94c]
Page Load Metrics (1786 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91154116157
domContentLoaded16072015176812359
load16072107178613063
domInteractive16072015176812359

highlights:

storybook

metamaskbot avatar Aug 25 '22 17:08 metamaskbot

Builds ready [a17b32a]
Page Load Metrics (1865 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002951334119
domContentLoaded16632228184514369
load16632262186514469
domInteractive16632228184514369

highlights:

storybook

metamaskbot avatar Aug 26 '22 06:08 metamaskbot

Builds ready [cebe284]
Page Load Metrics (1639 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882621123517
domContentLoaded1501177016227134
load1556177016396330
domInteractive1501177016227134

highlights:

storybook

metamaskbot avatar Sep 05 '22 10:09 metamaskbot