metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Add bn.js to resultions block to force only one version

Open segun opened this issue 3 years ago • 4 comments

Explanation

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • [ ] PR template is filled out
  • [ ] IF this PR fixes a bug, a test that would have caught the bug has been added
  • [ ] PR is linked to the appropriate GitHub issue
  • [ ] PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • [ ] Manual testing complete & passed
  • [ ] "Extension QA Board" label has been applied

segun avatar Jun 24 '22 14:06 segun

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 24 '22 14:06 github-actions[bot]

Builds ready [4fe401d]
Page Load Metrics (1707 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891931182311
domContentLoaded1579185017007034
load1579185017077134
domInteractive1579185017007034

metamaskbot avatar Jun 30 '22 15:06 metamaskbot

Builds ready [a940f74]
Page Load Metrics (1574 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8412597126
domContentLoaded1480172515655929
load1482172515745527
domInteractive1480172415655929

metamaskbot avatar Jul 28 '22 16:07 metamaskbot

Builds ready [3d70bf6]
Page Load Metrics (1706 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint851964210404194
domContentLoaded15062093169915776
load15062093170615374
domInteractive15062093169915776

metamaskbot avatar Aug 03 '22 13:08 metamaskbot

@segun @kumavis is working on this in #16410 -- should we close this?

brad-decker avatar Nov 11 '22 14:11 brad-decker

closing as work is continuing via #16410 and https://github.com/MetaMask/metamask-extension/issues/16533

danjm avatar Jan 06 '23 13:01 danjm