metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Improve accessibility of Spend Limit Permission screen options

Open ryanml opened this issue 2 years ago • 2 comments

Fixes: https://github.com/MetaMask/metamask-extension/issues/14883

Explanation

Explanation in issue

More Information

This also makes the spend limit options keyboard accessible

After

https://user-images.githubusercontent.com/8732757/173735041-08d5f5e5-9962-49d9-b68b-3fe75ea3beae.mov

Manual Testing Steps

  1. Follow steps in issue to find spend limit permission screen
  2. Ensure the options can be selected by clicking the radio button, clicking the accompanying text, and by tabbing through elements and clicking "Enter"

ryanml avatar Jun 15 '22 04:06 ryanml

@ryanml do you intend on carrying this PR over the finish line? If not can we close it and/or assign this to someone else

brad-decker avatar Aug 16 '22 20:08 brad-decker

@danjm @ryanml this pr is PR - PR1 and needs updated to be considered for inclusion. How should we prioritize this?

brad-decker avatar Sep 20 '22 16:09 brad-decker

@ryanml and @danjm I am converting this to a draft, if it doesn't get proper prioritization and attention in the next 30 days i'll close it. 🔨 🕐

brad-decker avatar Nov 04 '22 17:11 brad-decker