metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

[Bug]: ENS resolution highlights chars "m" and "1" in red text

Open seaona opened this issue 3 years ago • 6 comments

Describe the bug

Problem: ENS resolution highlights chars 1 and m from the latin alphabet in red text.

ens-resolution-char-highlight

Steps to reproduce

  1. Unlock Metamask
  2. Select Mainnet Network
  3. Click Send ETH
  4. Introduce the ENS address: mike1.eth

Error messages or log output

No response

Version

10.14.6

Build type

No response

Browser

Chrome, Firefox

Operating system

Linux

Hardware wallet

No response

Additional context

No response

seaona avatar May 30 '22 09:05 seaona

Update Note: I think this is related to prevent homograph attacks. Seems that Metamask highlights chars that look the same as in latin alphabet. See for example а, с, е, о, р, х from Cyrillic alphabet. So, Metamask is highlighting incorrectly the char m and 1 coming from the latin alphabet.

image

More here

seaona avatar May 30 '22 16:05 seaona

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity.\n\nThe MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible.\n\nThank you for your contributions.

github-actions[bot] avatar Jul 20 '23 19:07 github-actions[bot]

We don't want this to be closed :)

bschorchit avatar Jul 20 '23 22:07 bschorchit

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Oct 19 '23 00:10 github-actions[bot]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

github-actions[bot] avatar Dec 03 '23 00:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Aug 27 '24 02:08 github-actions[bot]

This seems to be intentional behavior, or at least it's stemming from the same logic that tries to cover confusable characters. m can be confused with rn and 1 can be confused with l, by the logic of the library being used

mirceanis avatar Sep 18 '24 10:09 mirceanis

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Dec 17 '24 12:12 github-actions[bot]