metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[e2e] Enabling/Disabling token conversion on testnets

Open seaona opened this issue 3 years ago • 3 comments

Explanation

New e2e testcase for checking that "Enabling/Disabling Token Conversion" toggle works correctly. This means testing that:

  • shows conversion on test network when toggle is activated
  • don't show conversion on test network when deactivated

More Information

  • Resolves #14606

Manual Testing Steps

  • Build test environment: yarn build:test
  • Run test
    • yarn test:e2e:single test/e2e/tests/advanced-settings.spec.js --browser=firefox
    • yarn test:e2e:single test/e2e/tests/advanced-settings.spec.js --browser=chrome

Pre-Merge Checklist

  • [X ] PR template is filled out
  • [ ] IF this PR fixes a bug, a test that would have caught the bug has been added
  • [X ] PR is linked to the appropriate GitHub issue
  • [ ] PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • [ ] Manual testing complete & passed
  • [ ] "Extension QA Board" label has been applied

seaona avatar May 09 '22 14:05 seaona

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 09 '22 14:05 github-actions[bot]

Builds ready [db1212f]
Page Load Metrics (1703 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint961826202373179
domContentLoaded1516184416908541
load1536191617039043
domInteractive1516184416908541

metamaskbot avatar Aug 02 '22 16:08 metamaskbot

@adonesky1 what do you mean by modify these tests so that there is a secondary currency for the test nets? So we are testing both scenarios, if it is present when activated and if it is not present when deactivated. Do you mean something else?

  • it('should show conversion on test networks when activated'
  • it('should not show conversion on test networks when deactivated'

For the mocking part, that is a great point, I could test only Localnetwork with API response mocked, instead of testing real testnets with real endpoint calls. Ty!!

seaona avatar Aug 10 '22 12:08 seaona

Builds ready [3dfaff7]
Page Load Metrics (1771 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892051182713
domContentLoaded15821998174911756
load16301998177110350
domInteractive15821997174911756

metamaskbot avatar Aug 10 '22 13:08 metamaskbot

Builds ready [b7dccd1]
Page Load Metrics (1823 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint931900207389187
domContentLoaded15752244179913465
load16772244182314168
domInteractive15752244179913465

metamaskbot avatar Aug 11 '22 14:08 metamaskbot

thank you for your great suggestions @adonesky1 !!

seaona avatar Aug 11 '22 14:08 seaona