metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Unable to proceed with tx bc of inaccurate/overly aggressive "Insufficient funds for gas" warning #13087

Open dragana8 opened this issue 2 years ago • 8 comments

As a user, I want a more informative “Insufficient funds for gas” warning on the send screen.

On the send screen, the user is shown an "Insufficient funds for gas" warning, but no other information about gas. So the user doesn't know if they have insufficient funds because prices are currently high or because the gas limit of the particular contract interaction they are attempting is high. So we show the estimated gas fee and warning message on the Send screen if user does not have enough tokens for the fee or total transaction amount is greater than the balance.

More info: https://github.com/MetaMask/metamask-extension/issues/13087

  • First part for #13087

Screenshots/Screencaps

BEFORE:

Screenshot 2022-05-25 at 15 23 08

AFTER:

Expand view (photo):

Screenshot 2022-09-20 at 13 35 42

Popup view (screencast):

https://user-images.githubusercontent.com/92527393/191248876-cc166a2c-8c66-407a-b678-4d92cc841dc0.mov

Expand view (screencast):

https://user-images.githubusercontent.com/92527393/191274599-0747eb81-b137-40de-9fa1-341c67bf4219.mov

dragana8 avatar May 06 '22 12:05 dragana8

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 06 '22 12:05 github-actions[bot]

can we have more information in the description? especially the before and after screenshots.

segun avatar May 24 '22 15:05 segun

@segun updated.

dragana8 avatar May 25 '22 13:05 dragana8

@danjm I pushed changes like we talked in the meeting today. Here are those changes. When you have time please review. Also @brad-decker, please review again. I also put screencast in description you to see how it is working now with this changes. Thank you! 😄

VSaric avatar Sep 08 '22 14:09 VSaric

Builds ready [6a5da6c]
Page Load Metrics (1743 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881531200308148
domContentLoaded15342049172111957
load15342049174312057
domInteractive15342049172111957

highlights:

storybook

metamaskbot avatar Sep 09 '22 15:09 metamaskbot

Builds ready [63ac074]
Page Load Metrics (1292 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8513697126
domContentLoaded11281693127313263
load11281693129213665
domInteractive11281693127313263

highlights:

storybook

metamaskbot avatar Sep 20 '22 12:09 metamaskbot

Builds ready [ac1759c]
Page Load Metrics (1417 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891660253426205
domContentLoaded11571763140913866
load12201763141713263
domInteractive11571763140913866

highlights:

storybook

metamaskbot avatar Sep 20 '22 14:09 metamaskbot

Verified by QA

mirjanaKukic avatar Sep 21 '22 12:09 mirjanaKukic

Builds ready [71c1459]
Page Load Metrics (1392 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89139112147
domContentLoaded12351634136610651
load12351707139210651
domInteractive12351634136610651

highlights:

storybook

metamaskbot avatar Sep 22 '22 15:09 metamaskbot

Builds ready [1dc678d]
Page Load Metrics (2460 ± 215 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint86155111189
domContentLoaded184235792436431207
load186436862460447215
domInteractive184235782436431207

highlights:

storybook

metamaskbot avatar Sep 30 '22 15:09 metamaskbot

Builds ready [d1e2852]
Page Load Metrics (2458 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint883255277684328
domContentLoaded207933252440318153
load207933252458313150
domInteractive207933252440318153

highlights:

storybook

metamaskbot avatar Oct 05 '22 16:10 metamaskbot

Builds ready [dfe8b32]
Page Load Metrics (2425 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88157115189
domContentLoaded22052627240012962
load22122728242513565
domInteractive22052627240012962

highlights:

storybook

metamaskbot avatar Oct 06 '22 08:10 metamaskbot

Builds ready [86aa964]
Page Load Metrics (2383 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint981831192211
domContentLoaded174828372343305146
load182629622383313150
domInteractive174828372343305146

highlights:

storybook

metamaskbot avatar Oct 26 '22 14:10 metamaskbot

Builds ready [9a60e8a]
Page Load Metrics (2253 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932329235481231
domContentLoaded176327502219254122
load183128152253261125
domInteractive176327502219254122

highlights:

storybook

metamaskbot avatar Oct 31 '22 14:10 metamaskbot

Builds ready [d64280c]
Page Load Metrics (2111 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87141103136
domContentLoaded16942482209518086
load16942496211118589
domInteractive16942482209518086

highlights:

storybook

metamaskbot avatar Nov 03 '22 15:11 metamaskbot

Builds ready [1e465b9]
Page Load Metrics (2379 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint992248229463222
domContentLoaded182726882352212102
load189227682379210101
domInteractive182726882352212102
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2498267 bytes
  • ui: 50169 bytes
  • common: -19243 bytes

highlights:

storybook

metamaskbot avatar Nov 10 '22 12:11 metamaskbot

Builds ready [e6800da]
Page Load Metrics (2425 ± 304 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982585341597287
domContentLoaded167744912404627301
load167744912425633304
domInteractive167744912404627301
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 16342 bytes
  • common: 104 bytes

highlights:

storybook

metamaskbot avatar Nov 22 '22 09:11 metamaskbot

Can I get one more eyes/review on this PR @danjm? 👀 Thank you in advance! 😄

VSaric avatar Nov 28 '22 15:11 VSaric

Builds ready [45e8ddd]
Page Load Metrics (2263 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1051881352211
domContentLoaded171131402247305146
load171131402263304146
domInteractive171131402247305146
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 16342 bytes
  • common: 104 bytes

highlights:

storybook

metamaskbot avatar Nov 28 '22 15:11 metamaskbot