metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Fixed enhanced gas fee bug

Open filipsekulic opened this issue 2 years ago • 9 comments

Fixes: https://github.com/MetaMask/metamask-extension/issues/13800

Screencast: https://user-images.githubusercontent.com/92310504/160845177-72378956-1a64-42c2-9a07-60d1f46c310a.mov

filipsekulic avatar Mar 25 '22 08:03 filipsekulic

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Mar 25 '22 08:03 github-actions[bot]

Builds ready [577966b]
Page Load Metrics (1292 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6813185157
domContentLoaded1195140512894823
load1209140512924522
domInteractive1195140512884823

highlights:

storybook

metamaskbot avatar Mar 30 '22 13:03 metamaskbot

Builds ready [1a10b1a]
Page Load Metrics (1386 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761346175272131
domContentLoaded1271156213766632
load1271156313866732
domInteractive1271156213766632

highlights:

storybook

metamaskbot avatar Apr 04 '22 11:04 metamaskbot

Verified by QA

mirjanaKukic avatar Apr 04 '22 13:04 mirjanaKukic

I think this looks pretty good, but I am realizing we need to add a migration. I have set some time on the calendar for next week to introduce that.

danjm avatar Apr 14 '22 10:04 danjm

Builds ready [2d5aec5]
Page Load Metrics (1290 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811447164294141
domContentLoaded1168145012877235
load1168145012907235
domInteractive1168145012877235

highlights:

storybook

metamaskbot avatar Apr 21 '22 15:04 metamaskbot

Builds ready [8018b50]
Page Load Metrics (1286 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762861054421
domContentLoaded1154142712767536
load1170142712867536
domInteractive1154142712767536

highlights:

storybook

metamaskbot avatar Apr 26 '22 09:04 metamaskbot

Builds ready [1be8c57]
Page Load Metrics (1718 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85139107168
domContentLoaded15742045171410752
load15832046171810550
domInteractive15742045171410752

highlights:

storybook

metamaskbot avatar Jul 06 '22 13:07 metamaskbot

@filipsekulic gonna need a rebase and I assume bump your migration number to avoid the conflict on 073

brad-decker avatar Sep 20 '22 15:09 brad-decker

Builds ready [6c87ef6]
Page Load Metrics (1289 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92161115178
domContentLoaded1149141212787637
load1149149712898943
domInteractive1149141212787637

highlights:

storybook

metamaskbot avatar Sep 27 '22 14:09 metamaskbot

@filipsekulic gonna need a rebase and I assume bump your migration number to avoid the conflict on 073

Done :white_check_mark:

filipsekulic avatar Sep 27 '22 14:09 filipsekulic

@danjm you reviewed this previously could you possibly take first pass at this now that it has a migration?

brad-decker avatar Sep 27 '22 22:09 brad-decker

Builds ready [990b2e7]
Page Load Metrics (2463 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95179128199
domContentLoaded200531772447237114
load200531772463236113
domInteractive200531772447237114

highlights:

storybook

metamaskbot avatar Sep 30 '22 12:09 metamaskbot

Builds ready [2afa67c]
Page Load Metrics (2130 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892099207434209
domContentLoaded16462703212119493
load16462703213019594
domInteractive16462702212119493

highlights:

storybook

metamaskbot avatar Oct 04 '22 09:10 metamaskbot

Builds ready [c63fcdf]
Page Load Metrics (2480 ± 214 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9696016918287
domContentLoaded176336852446448215
load176336852480445214
domInteractive176336852446448215
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 846 bytes
  • ui: 277 bytes
  • common: 115 bytes

highlights:

storybook

metamaskbot avatar Nov 15 '22 16:11 metamaskbot

Builds ready [403f128]
Page Load Metrics (2423 ± 219 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint921210186237114
domContentLoaded170937442408459220
load170937442423457219
domInteractive170937442408459220
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 846 bytes
  • ui: 277 bytes
  • common: 115 bytes

highlights:

storybook

metamaskbot avatar Nov 23 '22 11:11 metamaskbot

It might be useful to change this message also to reflect the network: @filipsekulic

Screenshot 2022-11-24 at 10 08 39 PM

jpuri avatar Nov 24 '22 16:11 jpuri

@jpuri Fixed: Screenshot 2022-11-25 at 12 07 16

filipsekulic avatar Nov 25 '22 11:11 filipsekulic

Builds ready [0a240d6]
Page Load Metrics (2337 ± 301 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint921232175244117
domContentLoaded167546302317634304
load169746302337626301
domInteractive167546302317634304
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 846 bytes
  • ui: 374 bytes
  • common: 115 bytes

highlights:

storybook

metamaskbot avatar Nov 25 '22 11:11 metamaskbot

Builds ready [8677314]
Page Load Metrics (2191 ± 196 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1041296189255122
domContentLoaded153634452173404194
load153634452191408196
domInteractive153634452173404194
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 844 bytes
  • ui: 374 bytes
  • common: 115 bytes

highlights:

storybook

metamaskbot avatar Dec 09 '22 12:12 metamaskbot

Builds ready [1f83ad8]
Page Load Metrics (1469 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94135113126
domContentLoaded1234162614598842
load1234162614698440
domInteractive1234162614598842
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 918 bytes
  • ui: 433 bytes
  • common: 0 bytes

metamaskbot avatar Mar 03 '23 09:03 metamaskbot

@danjm @brad-decker pinging for a re-review in this PR as you have requested changes in the past

bschorchit avatar Mar 13 '23 17:03 bschorchit

Builds ready [8d4210e]
Page Load Metrics (1585 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90178110199
domContentLoaded13461907154413063
load14171997158514469
domInteractive13461907154413063
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 918 bytes
  • ui: 433 bytes
  • common: 0 bytes

metamaskbot avatar Mar 13 '23 19:03 metamaskbot

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@06fba70). Click here to learn what that means. The diff coverage is 87.50%.

:exclamation: Current head 8d4210e differs from pull request most recent head 579f09a. Consider uploading reports for the commit 579f09a to get more accurate results

@@            Coverage Diff             @@
##             develop   #14203   +/-   ##
==========================================
  Coverage           ?   63.96%           
==========================================
  Files              ?      909           
  Lines              ?    35427           
  Branches           ?     8983           
==========================================
  Hits               ?    22658           
  Misses             ?    12769           
  Partials           ?        0
Impacted Files Coverage Δ
app/scripts/migrations/index.js 100.00% <ø> (ø)
ui/store/actions.ts 41.40% <0.00%> (ø)
...nced-gas-fee-defaults/advanced-gas-fee-defaults.js 97.14% <83.33%> (ø)
app/scripts/controllers/preferences.js 77.58% <100.00%> (ø)
app/scripts/controllers/transactions/index.js 69.40% <100.00%> (ø)
app/scripts/migrations/083.js 100.00% <100.00%> (ø)
ui/selectors/selectors.js 70.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 13 '23 19:03 codecov[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar Aug 06 '23 20:08 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar Aug 20 '23 20:08 github-actions[bot]

Closing in favor of https://github.com/MetaMask/metamask-extension/pull/20576

bschorchit avatar Aug 24 '23 20:08 bschorchit