metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

ENS resolution not working with IPNS

Open SamueleA opened this issue 4 years ago • 2 comments

Describe the bug ENS to IPNS name resolution doesn't work properly. For example, trying to go to uniswap through ENS, which uses IPNS, with metamask won't work: uniswap.eth/ Instead, after a long load, metamask redirects to https://app.ens.domains/name/uniswap.eth instead of redirecting with the contentHash. The contentHash is indeed properly set up because https://uniswap.eth.link resolves properly.

Steps to reproduce

  1. Unlock metamask and have mainnet selected.
  2. Type uniswap.eth/ in the browser search bar and press enter.
  3. After a few seconds of loading, metamask redirects to https://app.ens.domains/name/uniswap.eth

Expected behavior Instead of redirecting to https://app.ens.domains/name/uniswap.eth, metamask should redirect based on the IPNS contentHash such as [address].ipns.dweb.link.

Screenshots Peek 2021-02-25 13-50

Browser details:

  • OS: Ubuntu 20.04.2 LTS
  • Browser: Version 88.0.4324.182 (Official Build) (64-bit)
  • MetaMask Version: 9.0.5

Additional context The uniswap example is using dnsLink so the ENS app is redirecting to https://app-uniswap-org.ipns.dweb.link/ instead of [public-key].ipfs.dweb.link. That being said the same bug occurs when not using dnsLink. EG: samuelea.eth which on the ENS app resolves to https://k51qzi5uqu5dioykj9txcgydfd7rfuhm7jjdutk5p20uyv8vg9xmbts62yyh6t.ipns.dweb.link/ , but with Metamask resolved to https://app.ens.domains/name/samuelea.eth

Furthermore, I see there is a now closed ticket about this issue: https://github.com/MetaMask/metamask-extension/issues/9037 However, the problem with IPNS and metamask still persists.

SamueleA avatar Feb 25 '21 19:02 SamueleA

Hi this is not working for me too! Any update?

shaileshahuja avatar Nov 06 '21 09:11 shaileshahuja

Instead of redirecting to [address].ipns.dweb.link I recommend redirecting to https://uniswap-eth.ipns.dweb.link/ which preserves the ENS domain in the URL. See #9353

gerbz avatar Sep 20 '22 19:09 gerbz

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Jul 24 '23 10:07 github-actions[bot]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

github-actions[bot] avatar Sep 07 '23 12:09 github-actions[bot]