metamask-docs icon indicating copy to clipboard operation
metamask-docs copied to clipboard

Translate Custom UI examples to JSX

Open ziad-saab opened this issue 1 year ago • 17 comments

Description

  • Translate Custom UI examples to JSX
  • Add flaskOnly prop for TabItem
  • Add deprecation warning on Custom UI page
  • Add Custom UI with JSX page

Issue(s) fixed

Fixes #

Preview

image

Checklist

Complete this checklist before merging your PR:

  • [ ] If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • [ ] The proposed changes have been reviewed and approved by a member of the documentation team.

ziad-saab avatar Jun 11 '24 19:06 ziad-saab

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:21pm
metamask-docs-hftx ❌ Failed (Inspect) Jul 31, 2024 1:21pm

vercel[bot] avatar Jun 12 '24 16:06 vercel[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 17:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 17:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 17:06 github-actions[bot]

Probably important to mention somewhere that JSX syntax will only work with .tsx or .jsx files

hmalik88 avatar Jun 12 '24 17:06 hmalik88

Probably important to mention somewhere that JSX syntax will only work with .tsx or .jsx files

Just did that in my commit

Montoya avatar Jun 12 '24 19:06 Montoya

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 19:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 20:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 12 '24 20:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 13 '24 13:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 13 '24 15:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 13 '24 16:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 13 '24 19:06 github-actions[bot]

Preview published: zs/snaps-jsx

github-actions[bot] avatar Jun 13 '24 20:06 github-actions[bot]

This technically should not be merged until June 20....

Montoya avatar Jun 13 '24 20:06 Montoya

@Montoya Is this ready to merge?

alexandratran avatar Jun 20 '24 19:06 alexandratran

Almost ready to merge @alexandratran as soon as Extension and Flask v12 are published

Montoya avatar Jul 15 '24 15:07 Montoya