extension-port-stream icon indicating copy to clipboard operation
extension-port-stream copied to clipboard

wip fix for error handling

Open kumavis opened this issue 3 years ago • 3 comments

Fixes #22

webextension-polyfill-ts doesn't include the firefox variant with the error appended to it

and other typescript woes

kumavis avatar Sep 22 '21 07:09 kumavis

Merging #24 first might help with this. It made my editor more legible at least, because beforehand TypeScript was highlighting the entire function for each error. Now it only highlights the relevant property/line.etc.

Gudahtt avatar Sep 27 '21 13:09 Gudahtt

@kumavis @Gudahtt #25 seems related - which of these if any seems preferred today?

legobeat avatar Apr 29 '23 02:04 legobeat

I kinda like the idea of injecting the Chrome extension API rather than accessing it as a global.

Not sure why we'd want to use console.warn though. Passing the error up directly lets the caller decide how to handle this. Much more flexible.

Gudahtt avatar May 01 '23 12:05 Gudahtt