eth-trezor-keyring icon indicating copy to clipboard operation
eth-trezor-keyring copied to clipboard

Add method for OneKey device analysis

Open originalix opened this issue 3 years ago • 9 comments

Currently, there are many users who connect to OneKey hardware wallets via the trezor keyring because they use the same protocol. This PR adds a method to get the different vendor names for easy analysis.

originalix avatar Aug 18 '22 03:08 originalix

@danjm this could be what we need to differentiate OneKey and Trezor devices here.

AlexJupiter avatar Aug 24 '22 10:08 AlexJupiter

Hey @AlexJupiter @danjm

Think we need approve to continue the workflow.

🙏🙏

rayston92 avatar Sep 22 '22 10:09 rayston92

I pressed the "approve & run" button.

mcmire avatar Sep 22 '22 15:09 mcmire

Hey @mcmire

require-additional-reviewer action failed, can you help to see what needs to be done ? 🙏

originalix avatar Sep 23 '22 01:09 originalix

I pressed the "approve & run" button.

@mcmire This ci issue is a github api error, can you help me look at it? Thanks 🙏

originalix avatar Sep 27 '22 01:09 originalix

Yeah, this check regularly fails on forks. I'll need to get someone with admin access to merge this. I can do that tomorrow.

mcmire avatar Sep 27 '22 02:09 mcmire

Yeah, this check regularly fails on forks. I'll need to get someone with admin access to merge this. I can do that tomorrow.

Hey @mcmire, have you shown this pr to anyone with admin access today so that we can continue to push for this pr to be merged into 😃

originalix avatar Sep 28 '22 06:09 originalix

@mcmire @danjm I think we should do this data collection PR first https://github.com/MetaMask/metamask-extension/pull/15630 to understand how many OneKey devices are using MetaMask. Then we can make a decision on what to do with this one.

AlexJupiter avatar Oct 04 '22 12:10 AlexJupiter

Aha. Sounds good!

mcmire avatar Oct 04 '22 15:10 mcmire