eth-json-rpc-middleware icon indicating copy to clipboard operation
eth-json-rpc-middleware copied to clipboard
verified publisher icon MetaMask

[14.x] fix: support ethermint's EIP712 implementation

Open mtsitrin opened this issue 1 year ago • 3 comments

MM is broken since v12.1.1 for cosmos chains that use https://github.com/evmos/ethermint as EVM adapter.

Ethermint uses hard coded "cosmos" string as the VerifyingContract field, which is broken since validateVerifyingContract was introduced in MM.

This PR adds support to allow "cosmos" as the VerifyingContract value.

mtsitrin avatar Sep 09 '24 10:09 mtsitrin

+1

omritoptix avatar Sep 09 '24 10:09 omritoptix

+1

testinginprod avatar Sep 09 '24 10:09 testinginprod

@jpuri

mtsitrin avatar Sep 10 '24 08:09 mtsitrin

Thanks again for the contribution @mtsitrin ! I've just pushed a few minor changes to make this match the version of this that we merged into the main branch and shipped to production: https://github.com/MetaMask/eth-json-rpc-middleware/pull/334

Gudahtt avatar Oct 02 '24 12:10 Gudahtt

This has been published as @metamask/[email protected]

Gudahtt avatar Oct 02 '24 13:10 Gudahtt