eth-json-rpc-filters icon indicating copy to clipboard operation
eth-json-rpc-filters copied to clipboard

fix: make `intToHex` produce valid `Quantity`

Open josepot opened this issue 3 years ago • 1 comments

Fixes #70

josepot avatar Sep 01 '22 10:09 josepot

Thanks for the contribution! Completely agree with the "Quantity" data type not having the leading zero, that is wrong, but there were some cases where the leading zero was required. Not within an RPC payload, but when the hex string is used for certain operations that expect the input to have an even length (so that each pair of digits can be used to represent one byte).

I'm unsure if that concern applies in this case. I'll audit the uses of the intToHex funciton to find out.

Gudahtt avatar Sep 07 '22 23:09 Gudahtt