eth-faucet icon indicating copy to clipboard operation
eth-faucet copied to clipboard

Proposed changes for multi-testnet faucet option

Open cooganb opened this issue 4 years ago • 2 comments

Hey there, two main changes:

  • The first is on the webapp side, where it's mainly about providing a valid etherscan URL that's not just ropsten
  • The second is proposed changes on server file, showing where I think the indicated network will be.

I'm not familiar enough with the codebase or ethQuery to make the best decision about this, but will message you on slack as well.

The other thing I'm stuck on is the best way to encode which network the user wants when sending the POST request -- it could either be stuck onto the front of the rawdata string that's parsed, or the webapp can format the req into a JSON. but I think parsing a JSON on the server side might be a little too weird, but you would know best.

cooganb avatar May 17 '21 01:05 cooganb

you should also checkout https://github.com/MetaMask/test-dapp/ and see if it meets your needs

kumavis avatar Jun 04 '21 05:06 kumavis

also going to need infura api keys for each network

kumavis avatar Jun 04 '21 05:06 kumavis