core
core copied to clipboard
This monorepo is a collection of packages used across multiple MetaMask clients
## Problem To make the Wallet Framework a success, we want developers to use the messenger within the UI and other places. However, currently, it is very difficult for them...
Once all the Keyring updates have been completed and we are ready to release the controller, we should create a DRAFT PR to pull those changes into Mobile
Once all the Keyring updates have been completed and we are ready to release the controller, we should create a DRAFT PR to pull those changes into Extension
Currently, our [Keyring type](https://github.com/MetaMask/utils/blob/main/src/keyring.ts) only allows adding new accounts sequentially, or more specifically, does not provide a standardized way to specify which index (or even derivation path) should be used...
## Explanation I missed this when introducing the `KeyringRequest.origin` feature. - https://github.com/MetaMask/core/pull/5871 The main problem is that this controller is dispatching "raw Snap request", thus, preventing any type-checking when doing...
On mobile, the instructions to integrate a preview build into the client are slightly different than on extension. Instead of e.g. ``` "@metamask/controller-utils@^1.1.4": "npm:@metamask-previews/[email protected]" ``` you must say (note the...
The tool used for the release workflow (`create-release-branch`) currently shows warnings about potential hazards to the author of each release, but these warnings are only viewable to the release author....
- When to use `dependencies`, `devDependencies`, and `peerDependencies` for controllers - If your controller is talking to another controller via the messenger, you should place that controller in both `devDependencies`...
If an engineer needs to redo a release due to to a bad changelog or incorrect version bump, then currently we ask them to submit a PR that reverts the...
## Motivation - Currently, we manually enumerate each individual internal action type definition in controller files, and then manually enumerate them again in the type union for internal actions ([example](https://github.com/MetaMask/core/blob/main/packages/network-controller/src/NetworkController.ts#L286-L346))....