core icon indicating copy to clipboard operation
core copied to clipboard

This monorepo is a collection of packages used across multiple MetaMask clients

Results 595 core issues
Sort by recently updated
recently updated
newest added

## Motivation - Middleware functions in `eth-json-rpc-middleware`, `eth-json-rpc-engine`, `eth-json-rpc-infura` are ["return type-only" generics](https://google.github.io/styleguide/tsguide.html#return-type-only-generics) with implicit generic parameters. This is a discouraged pattern. - Redefining the functions to expose the generic...

team-shared-libraries

The network client is a bit too low-level to be used directly. When working with a network client, especially resolving a network client ID, you have to be aware that...

team-wallet-api-platform
team-shared-libraries

The next version bump for TypeScript in `core` and `metamask-module-template` will mark an update to version 4.9, which will make the `satisfies` operator keyword available for use (https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#satisfies). The `satisfies`...

team-shared-libraries

## Explanation * Add named key for ChainPatrol so that we can consume their list * They have forked `MetaMask/eth-phishing-detect` so it is the same shape as `eth_phishing_detect_config` named key...

The `KeyringController` method `addAccountWithoutUpdate` no longer works; it does add the account, but not without updating state to include thew new account. This was broken in `@metamask/[email protected]`

bug
team-wallet-framework

## Explanation ## References Relates to the upgrade on mobile to controllers v53: https://github.com/MetaMask/metamask-mobile/pull/7999 ## Changelog ### `@metamask/network-controller` - ****: Add internal destroyed variable to stop on going lookupNetwork function....

Go through and ensure that all changelog entries (at least, those we've added as a part of monorepo releases) have PRs. We may also be able to automate this. See:...

team-wallet-framework

In calculating `maxPriorityFeePerGas` as following code: https://github.com/MetaMask/core/blob/1dadf04f77211e3650d36be86aa0934750ec9a44/packages/gas-fee-controller/src/fetchGasEstimatesViaEthFeeHistory/calculateGasFeeEstimatesForPriorityLevels.ts#L75 ``` const medianPriorityFee = medianOf(priorityFees); const adjustedPriorityFee = medianPriorityFee .mul(settings.priorityFeePercentageMultiplier) .divn(100); ``` If minimum priority fee in block history is same to the...

team-confirmations

Epic
team-shared-libraries

Epic
team-shared-libraries