core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

expose KeyringControler.verifyPassword

Open owencraston opened this issue 2 years ago • 2 comments

Currently we are validating passwords by calling await KeyringController.submitPassword(credentials.password) which is a heavy operation and is dramatically slowing down the UI. I see that base KeyringController has a verifyPassword method that is not exposed by this wrapper. We could expose this method so we can check passwords without running a full update.

owencraston avatar Jul 08 '22 19:07 owencraston

We do now expose verifyPassword but not in the recommended way. We should also update on mobile.

desi avatar May 01 '24 15:05 desi

Potential blocker for Wallet Frame - Desi add to release (once I create).

Remaining work is to add action.

desi avatar May 01 '24 15:05 desi