core icon indicating copy to clipboard operation
core copied to clipboard
verified publisher icon MetaMask

KeyringController:signPersonalMessage does not fail if empty data is passed.

Open jpuri opened this issue 3 years ago • 1 comments

KeyringController:signMessage fails if empty data is passed but KeyringController:signPersonalMessage does not fails if empty data is passed.

jpuri avatar Apr 25 '22 09:04 jpuri

Does the spec require that the data be non-empty? Worth confirming that - maybe this is fine.

Also we should check to see if it's possible that a dapp is relying upon this. We might be forced to preserve this behavior for backwards-compatibility.

Gudahtt avatar Apr 25 '22 19:04 Gudahtt