core
core copied to clipboard
A GitHub release should not be created until after the release is approved by the NPM publishers team
Currently, when a release PR is merged:
- A Git tag is pushed
- The GitHub release is created
-
npm publishis run in dry-run mode - The release workflow is paused while waiting for approval from NPM publishers
- The release is approved
-
npm publishis run in non-dry-run mode
This means that a release is cancelled and needs to be re-created, the Git tag and GitHub release need to be removed first. We can avoid from needing to remember to do this if we change the workflow to:
-
npm publishis run in dry-run mode - The release workflow is paused while waiting for approval from NPM publishers
- The release is approved
- A Git tag is pushed
- The GitHub release is created
-
npm publishis run in non-dry-run mode