core
core copied to clipboard
excessive use of safelyExecute
should be used sparingly, eg only by polling handlers
additionally its used unsafely in some places, expecting a return value and not tolerating undefined
Even polls shouldn't ignore all errors, if we can help it anyway. Ideally we'd catch and log expected errors like network problems, and throw unexpected ones that could indicate a problem with our code.
Ignoring all errors makes sense if we expect errors and can't anticipate what they will be (e.g. when dealing with custom networks). It seems unavoidable in that case. But for known APIs we should be able to identify all expected errors.