core icon indicating copy to clipboard operation
core copied to clipboard

excessive use of safelyExecute

Open kumavis opened this issue 4 years ago • 2 comments

should be used sparingly, eg only by polling handlers

kumavis avatar Jul 28 '21 02:07 kumavis

additionally its used unsafely in some places, expecting a return value and not tolerating undefined

kumavis avatar Jul 28 '21 03:07 kumavis

Even polls shouldn't ignore all errors, if we can help it anyway. Ideally we'd catch and log expected errors like network problems, and throw unexpected ones that could indicate a problem with our code.

Ignoring all errors makes sense if we expect errors and can't anticipate what they will be (e.g. when dealing with custom networks). It seems unavoidable in that case. But for known APIs we should be able to identify all expected errors.

Gudahtt avatar Jul 29 '21 16:07 Gudahtt