core icon indicating copy to clipboard operation
core copied to clipboard

wip fix?

Open adonesky1 opened this issue 1 year ago • 1 comments

Explanation

Some change was introduced that caused an issue where pending approvals are not getting cleared when wallet_switchEthereumChain calls occur.

This causes an issue in the QueuedRequestController where the #processingRequestCount value does not get updated correctly since certain pending confirmation rejections never resolve.

This then causes this condition to never obtain, meaning that the this.#originOfCurrentBatch never gets unset which causes subsequent requests to always get queued.

References

Changelog

@metamask/package-a

  • <CATEGORY>: Your change here
  • <CATEGORY>: Your change here

@metamask/package-b

  • <CATEGORY>: Your change here
  • <CATEGORY>: Your change here

Checklist

  • [ ] I've updated the test suite for new or updated code as appropriate
  • [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

adonesky1 avatar Oct 21 '24 19:10 adonesky1

@metamaskbot publish-preview

adonesky1 avatar Oct 21 '24 19:10 adonesky1