MetaMask
Remove `NotificationController`
Removes the NotificationController in favor of NotificationServicesController, see https://github.com/MetaMask/core/pull/4809
Removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected]
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
The @MetaMask/notifications team will align with the @MetaMask/snaps team on this.
Our notifications team were preparing the "notification unification" in Q1 (unify snaps, confirmations, our back-end notifications, and future notifications or alerts), but, as this seems to be moving forward, we can expedite it 😅.
We can have a brainstorm and discussion on how we can create a unified/orchestrated notification controller that:
- Allows other teams to manage and own their own notifications. Make it easy to contribute and extend.
- Create a clean/minimal interface that reflects 1:1 with the UI
- Prevent god controllers (e.g. a notification controller that becomes too large and hard to manage, our team is already starting to feel this as we are planning to release more and more notifications).
This can be done in iterative steps. I'm just bringing this up as the current NotificationServicesController is very large, very complex, has confusing method names, and is getting harder and harder to extend.