core icon indicating copy to clipboard operation
core copied to clipboard

fix: add missing settings from mobile patch

Open sahar-fehri opened this issue 1 year ago • 0 comments

Explanation

Looking at the preferences-controller patch on mobile; noticed that core is missing some of those updates. This PR brings the updates needed on mobile to core.

References

  • Related to: mobile patch for preferences controller (https://github.com/MetaMask/metamask-mobile/blob/main/patches/%40metamask%2Bpreferences-controller%2B11.0.0.patch)

Changelog

@metamask/assets-controllers

  • BREAKING: Rename openSeaEnabled to displayNftMedia in NftController
  • BREAKING: Remove setApiKey function from NftController since we do not use opensea anymore for NFT data
  • BREAKING: Remove openSeaApiKey from NftController

@metamask/preferences-controller

  • BREAKING: Rename openSeaEnabled to displayNftMedia
  • BREAKING: Rename setOpenSeaEnabled to setDisplayNftMedia
  • ADDED: Added useSafeChainsListValidation to preferences controller state
  • ADDED: Added setUseSafeChainsListValidation function to update useSafeChainsListValidation value .

Checklist

  • [ ] I've updated the test suite for new or updated code as appropriate
  • [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

sahar-fehri avatar Oct 09 '24 14:10 sahar-fehri