core icon indicating copy to clipboard operation
core copied to clipboard

[network-controller] Add `lookupNetwork` timeout

Open Gudahtt opened this issue 1 year ago • 0 comments

The NetworkController method lookupNetwork doesn't currently have a timeout. The default fetch timeout is quite long, leading to long delays in situations where we're waiting to know whether the network is accessible or not. We should add a timeout of 5 seconds. We can assume that networks that take longer than that to respond are inaccessible.

Acceptance Criteria

  • Add a timeout on the lookupNetwork method
  • Add unit tests for this change

Gudahtt avatar Jul 03 '24 16:07 Gudahtt