core icon indicating copy to clipboard operation
core copied to clipboard

Adapt to EIP-1193 provider changes

Open mcmire opened this issue 1 year ago • 2 comments

After SafeEventEmitterProvider is updated to support EIP-1193, we should adapt to the changes:

  • Calling sendAsync will be deprecated; we should use request instead.
    • Here is where we are doing this in the core repo:
      • FakeProvider
      • NetworkController tests
    • Additionally, there are places where we expect the provider that NetworkController returns to have a sendAsync method, and similarly, we should change this to request and update the method signature appropriately:
      • SelectedNetworkController tests
      • createAutoManagedNetworkClient tests
  • Note that there are places in core where we are calling sendAsync on eth-query. We don't need to worry about those in this ticket; they are being addressed in a different ticket.

mcmire avatar Mar 21 '24 21:03 mcmire

Any chance to have that coming?

MakiBM avatar Jun 07 '24 16:06 MakiBM

@MakiBM We are working on this now :)

mcmire avatar Jun 26 '24 17:06 mcmire