Convert NftDetectionController from BaseControllerV1 to BaseControllerV2

[desi]

Considering that converting TokenDetectionController to BaseController v2 took longer than expected due to unforeseen changes, we want to be more conscientious about converting NftDetectionController.

Figure out all of the changes we would want to make in upgrading this controller, outline those changes here and create new tickets if appropriate.