core icon indicating copy to clipboard operation
core copied to clipboard

Extract the detector from `eth-phishing-detect` to this repo

Open mcmire opened this issue 11 months ago • 1 comments

Currently, select parts of the eth-phishing-detect repo is under our codeownership. We added this because we wanted to make sure to approve any changes to the detector. However, this repo is different than our other repos in that several people contribute to it, and some are outside of Consensys. Therefore, this change has caused some concerns recently.

We had always planned to extract the detector to this repo so it that it could be maintained separately from the config. Now seems like a good time to do that.

mcmire avatar Mar 06 '24 23:03 mcmire

Copy the code directly into the phishing controller package. Rewrite tests (use existing as inspiration). Convert to Typescript. Don't bring along the default config.

Create issue on eth-phishing-detect for deleting old one and re-release eth-phishing-detect as a major release. This is just for the above info.

desi avatar Mar 07 '24 16:03 desi