core icon indicating copy to clipboard operation
core copied to clipboard

Investigate whether "cancel" transactions should be pushed to state in Transactions Controller as we do with "speed up" transactions

Open adonesky1 opened this issue 2 years ago • 1 comments

Is there some reason we don't add "cancel" transactions into the transactions array like we do with speedup transactions? cancel: https://github.com/MetaMask/core/blob/a3b454eadbc9e974a6ee4a2729baf54171d422ed/packages/transaction-controller/src/TransactionController.ts#L824 speedup: https://github.com/MetaMask/core/blob/a3b454eadbc9e974a6ee4a2729baf54171d422ed/packages/transaction-controller/src/TransactionController.ts#L946

adonesky1 avatar Apr 05 '23 21:04 adonesky1

Hey @adonesky1 , Can I work on it??

ptdatta avatar Apr 16 '23 20:04 ptdatta