core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: add support for consensys zkevm network (Linea)

Open VGau opened this issue 2 years ago • 5 comments

PR Title Added support for ConsenSys zkEVM test network (Linea).

Description It was added ConsenSys zkEVM test network (Linea) support to our Network Controller.

  • CHANGED:
    • The network controller has been updated to support Consensys zkEVM (Linea)
    • New test cases have been added to use ConsenSys zkEVM network (Linea)

Checklist

  • [X] Tests are included if applicable
  • [X] Any added code is fully documented

VGau avatar Mar 13 '23 16:03 VGau

@mcmire Can you confirm?

sethkfman avatar Mar 17 '23 21:03 sethkfman

@Gudahtt I notice you left a comment in Slack about this PR, are you good with this?

mcmire avatar Mar 20 '23 17:03 mcmire

@Gudahtt I notice you left a comment in Slack about this PR, are you good with this?

Yes I am good with this PR thanks 😄

VGau avatar Mar 20 '23 17:03 VGau

Nope, no objections. But I will add a DO-NOT-MERGE label for now because since this was approved, the strategy used to support this network on mobile has changed. We need to revisit whether we need a change to the network controller at all, or whether this can be handled solely in mobile instead.

Gudahtt avatar Mar 23 '23 22:03 Gudahtt

Now that https://github.com/MetaMask/core/pull/1423 has been merged, should we close this?

mcmire avatar Jul 21 '23 22:07 mcmire