api-specs icon indicating copy to clipboard operation
api-specs copied to clipboard

Add permission method for wallet_getLocale

Open meppsilon opened this issue 3 years ago • 1 comments

I added a simple permission for wallet_getLanguage. I wasn't sure how detailed and specific we should make this permission but I see a possible improvement: converting LanguageResult to a enum-like data type where we specify exactly what languages would be returned instead of a returning it as a general "string" type.

meppsilon avatar Apr 13 '22 19:04 meppsilon

Looks good, you also need to add the method as a $ref in this file: https://github.com/MetaMask/api-specs/blob/main/metamask-openrpc.json#L7

shanejonas avatar Apr 14 '22 15:04 shanejonas