KeyringController icon indicating copy to clipboard operation
KeyringController copied to clipboard

Question: How to fork and build this package locally to edit and use within the metamask-extension

Open AngusBurton opened this issue 2 years ago • 3 comments

Hello, I'm trying to fork and build this package locally to edit and use as a dependency within the metamask-extension repo. Unfortunately I've failed to do so.

I've tried linking it within the package json using yarn install <filepath> which successfully creates a link to the local module however when running yarn start on the metamask-extension repo it produces an error: TypeError: Tried to access an environmental variable "_nodeLRUCacheForceNoSymbol" that wasn't declared in builds.yml I did try adding the env like it says however it keeps asking for envs to add to builds.yml which ultimately doesn't work.

I've also tried just putting the package directly inside the metamask-extension repo and change the imports to the filepath of the local package. But this caused many dependency issues.

Is there a better way to go about this? If you have any ideas I'd love to know. Thanks.

AngusBurton avatar Dec 12 '23 07:12 AngusBurton

Hi @AngusBurton are you able to resolve this?

Cognacy avatar Dec 21 '23 00:12 Cognacy

Hi @Cognacy, no I haven't been able to resolve this.

AngusBurton avatar Dec 21 '23 01:12 AngusBurton

Have you tried listing your fork as a dependency in package.json? https://stackoverflow.com/questions/28728665/how-to-use-private-github-repo-as-npm-dependency

MajorLift avatar Dec 21 '23 04:12 MajorLift